Re: [PATCH v0 3/4] drivers: edac: Add cache erp driver for Last Level Cache Controller (LLCC)

2018-07-30 Thread vnkgutta
On 2018-07-28 20:49, Borislav Petkov wrote: On Wed, Jul 25, 2018 at 10:44:56AM -0700, Venkata Narendra Kumar Gutta wrote: Add cache error reporting driver for single and double bit errors on Last Level Cache Controller (LLCC) cache. This driver takes care of dumping registers and add config

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-08 Thread vnkgutta
Reminder. Would someone review this EDAC patch series? Thanks, Narendra On 2018-08-01 13:33, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver supports erp for Last Level Cache Controller (LLCC). This driver

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-10 Thread vnkgutta
On 2018-08-09 20:59, Borislav Petkov wrote: On Wed, Aug 01, 2018 at 01:33:34PM -0700, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver Please write out those abbreviations. Done, I just followed the other

Re: [PATCH v1 2/4] drivers: soc: Add support to register LLCC EDAC driver

2018-08-10 Thread vnkgutta
On 2018-08-10 10:21, Evan Green wrote: On Wed, Aug 1, 2018 at 1:33 PM Venkata Narendra Kumar Gutta wrote: Cache error reporting controller is to detect and report single and double bit errors on Last Level Cache Controller (LLCC) cache. Add required support to register LLCC EDAC driver as

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-10 Thread vnkgutta
On 2018-08-10 10:23, Evan Green wrote: On Wed, Aug 1, 2018 at 1:34 PM Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver supports erp for Last Level Cache Controller (LLCC). This driver takes care of dumping

Re: [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC)

2018-08-24 Thread vnkgutta
On 2018-08-23 16:01, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: Currently, boradcast base is set to end of the LLCC banks, which may s/boradcast/broadcast/ I'll correct this typo in the next version. not be correct always. As the number of

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-23 16:04, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for Single Bit Errors (SBEs) and Double Bit Errors (DBEs). As of now, this driver supports erp for Last Level Cache Controller

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-24 09:11, Stephen Boyd wrote: Quoting Venkata Narendra Kumar Gutta (2018-08-17 17:08:34) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2..da8f150 100644 --- a/drivers/edac/Kconfig +++ b/drivers/edac/Kconfig @@ -460,4 +460,32 @@ config EDAC_TI Support

Re: [PATCH v2 2/4] drivers: soc: Add support to register LLCC EDAC driver

2018-08-24 Thread vnkgutta
On 2018-08-23 16:01, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: Cache error reporting controller is to detect and report single Should be "Cache error reporting controller detects and reports single"... Ok. I'll update this in next patchset.

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-23 16:07, Evan Green wrote: On Thu, Aug 23, 2018 at 4:04 PM Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: > > From: Channagoud Kadabi Also checkpatch.pl complains a bit about this patch: WARNING: Non-standard signature:

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-24 13:18, Evan Green wrote: On Fri, Aug 24, 2018 at 11:32 AM wrote: On 2018-08-23 16:04, Evan Green wrote: > On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta > wrote: >> >> From: Channagoud Kadabi >> >> Add error reporting driver for Single Bit Errors (SBEs) and

Re: [PATCH v2 4/4] dt-bindigs: msm: Update documentation of qcom,llcc

2018-08-22 Thread vnkgutta
On 2018-08-20 12:53, Rob Herring wrote: On Fri, Aug 17, 2018 at 05:08:35PM -0700, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes.

Re: [PATCH v3 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-04 Thread vnkgutta
On 2018-08-30 05:11, Borislav Petkov wrote: On Tue, Aug 28, 2018 at 05:42:26PM -0700, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for Single Bit Errors (SBEs) and Double Bit Errors (DBEs). As of now, this driver supports error reporting for Last

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread vnkgutta
On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { + { .compatible = "qcom,llcc-edac" }, + { }, +}; + Hi Venkata, Devicetree binding for llcc is updated, but

Re: [PATCH v4 4/4] dt-bindings: msm: Update documentation of qcom,llcc

2018-09-06 Thread vnkgutta
On 2018-09-06 06:16, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Signed-off-by:

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-10 Thread vnkgutta
On 2018-09-06 22:02, Sai Prakash Ranjan wrote: On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { +    { .compatible =

Re: [PATCH v0 3/4] drivers: edac: Add cache erp driver for Last Level Cache Controller (LLCC)

2018-07-30 Thread vnkgutta
On 2018-07-28 20:49, Borislav Petkov wrote: On Wed, Jul 25, 2018 at 10:44:56AM -0700, Venkata Narendra Kumar Gutta wrote: Add cache error reporting driver for single and double bit errors on Last Level Cache Controller (LLCC) cache. This driver takes care of dumping registers and add config

Re: [PATCH v2 4/4] dt-bindigs: msm: Update documentation of qcom,llcc

2018-08-22 Thread vnkgutta
On 2018-08-20 12:53, Rob Herring wrote: On Fri, Aug 17, 2018 at 05:08:35PM -0700, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes.

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-10 Thread vnkgutta
On 2018-08-09 20:59, Borislav Petkov wrote: On Wed, Aug 01, 2018 at 01:33:34PM -0700, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver Please write out those abbreviations. Done, I just followed the other

Re: [PATCH v1 2/4] drivers: soc: Add support to register LLCC EDAC driver

2018-08-10 Thread vnkgutta
On 2018-08-10 10:21, Evan Green wrote: On Wed, Aug 1, 2018 at 1:33 PM Venkata Narendra Kumar Gutta wrote: Cache error reporting controller is to detect and report single and double bit errors on Last Level Cache Controller (LLCC) cache. Add required support to register LLCC EDAC driver as

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-10 Thread vnkgutta
On 2018-08-10 10:23, Evan Green wrote: On Wed, Aug 1, 2018 at 1:34 PM Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver supports erp for Last Level Cache Controller (LLCC). This driver takes care of dumping

Re: [PATCH v2 2/4] drivers: soc: Add support to register LLCC EDAC driver

2018-08-24 Thread vnkgutta
On 2018-08-23 16:01, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: Cache error reporting controller is to detect and report single Should be "Cache error reporting controller detects and reports single"... Ok. I'll update this in next patchset.

Re: [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC)

2018-08-24 Thread vnkgutta
On 2018-08-23 16:01, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: Currently, boradcast base is set to end of the LLCC banks, which may s/boradcast/broadcast/ I'll correct this typo in the next version. not be correct always. As the number of

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-23 16:04, Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for Single Bit Errors (SBEs) and Double Bit Errors (DBEs). As of now, this driver supports erp for Last Level Cache Controller

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-23 16:07, Evan Green wrote: On Thu, Aug 23, 2018 at 4:04 PM Evan Green wrote: On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta wrote: > > From: Channagoud Kadabi Also checkpatch.pl complains a bit about this patch: WARNING: Non-standard signature:

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-24 09:11, Stephen Boyd wrote: Quoting Venkata Narendra Kumar Gutta (2018-08-17 17:08:34) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index 57304b2..da8f150 100644 --- a/drivers/edac/Kconfig +++ b/drivers/edac/Kconfig @@ -460,4 +460,32 @@ config EDAC_TI Support

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread vnkgutta
On 2018-08-24 13:18, Evan Green wrote: On Fri, Aug 24, 2018 at 11:32 AM wrote: On 2018-08-23 16:04, Evan Green wrote: > On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta > wrote: >> >> From: Channagoud Kadabi >> >> Add error reporting driver for Single Bit Errors (SBEs) and

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-08 Thread vnkgutta
Reminder. Would someone review this EDAC patch series? Thanks, Narendra On 2018-08-01 13:33, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for SBEs and DBEs. As of now, this driver supports erp for Last Level Cache Controller (LLCC). This driver

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread vnkgutta
On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { + { .compatible = "qcom,llcc-edac" }, + { }, +}; + Hi Venkata, Devicetree binding for llcc is updated, but

Re: [PATCH v4 4/4] dt-bindings: msm: Update documentation of qcom,llcc

2018-09-06 Thread vnkgutta
On 2018-09-06 06:16, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Signed-off-by:

Re: [PATCH v3 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-04 Thread vnkgutta
On 2018-08-30 05:11, Borislav Petkov wrote: On Tue, Aug 28, 2018 at 05:42:26PM -0700, Venkata Narendra Kumar Gutta wrote: From: Channagoud Kadabi Add error reporting driver for Single Bit Errors (SBEs) and Double Bit Errors (DBEs). As of now, this driver supports error reporting for Last

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-10 Thread vnkgutta
On 2018-09-06 22:02, Sai Prakash Ranjan wrote: On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { +    { .compatible =