Am 29.01.2013 19:03, schrieb Joe Perches:
> On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
>> How about the following (from today's linux-next). They appear to be
>> trying to do the same calculation, once with + and once with |.
>
> (cc'ing the original developer and Russell King)
>
>
Am 27.01.2013 22:00, schrieb Joe Perches:
> On Sun, 2013-01-27 at 23:19 +0300, Dan Carpenter wrote:
>> On Sun, Jan 27, 2013 at 12:04:38PM -0800, Joe Perches wrote:
>>> Wouldn't it be clearer still to use | instead of +
>> Yeah. I think it would be, but adding bitflags together instead of
>> doin
Am 22.02.2013 20:06, schrieb Greg KH:
> On Fri, Feb 22, 2013 at 07:58:35PM +0100, walter harms wrote:
>>
>>
>> Am 22.02.2013 19:07, schrieb Kumar Amit Mehta:
>>> fix for instances of DMA buffer on stack(being passed to usb_control_msg)
>>> for
>>&
Am 23.02.2013 18:34, schrieb Dan Carpenter:
> On Sat, Feb 23, 2013 at 04:59:43PM +0100, walter harms wrote:
>>>> or is it possible to pass one byte
>>>> in a register ? (aka char/int) without allocating ?
>>>
>>> Nope, the USB host controllers must b
Am 22.02.2013 19:07, schrieb Kumar Amit Mehta:
> fix for instances of DMA buffer on stack(being passed to usb_control_msg) for
> the USB-DUXfast Board driver.
>
> Signed-off-by: Kumar Amit Mehta
> ---
> drivers/staging/comedi/drivers/usbduxfast.c | 30
> ---
> 1 file
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression
Am 14.09.2012 10:15, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> position p1,p2;
> expression
Am 03.11.2012 11:58, schrieb Julia Lawall:
> From: Julia Lawall
>
> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
>
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression list e
Am 03.11.2012 11:58, schrieb Julia Lawall:
> From: Julia Lawall
>
> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
>
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression list e
Am 03.11.2012 15:14, schrieb Julia Lawall:
> On Sat, 3 Nov 2012, walter harms wrote:
>
>>
>>
>> Am 03.11.2012 11:58, schrieb Julia Lawall:
>>> From: Julia Lawall
>>>
>>> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
>
Am 29.07.2012 02:45, schrieb Fengguang Wu:
> This quiets the coccinelle warnings:
>
> net/bridge/netfilter/ebtable_filter.c:107:1-3: WARNING: PTR_RET can be used
> net/bridge/netfilter/ebtable_nat.c:107:1-3: WARNING: PTR_RET can be used
> net/ipv6/netfilter/ip6table_filter.c:65:1-3: WARNING: PTR
Am 05.09.2012 14:34, schrieb Dan Carpenter:
> We should decrement "i" before doing the free_irq(). If we call this
> because request_threaded_irq() failed then we don't want to free the
> thing which failed. Or in the case where we get here because
> power_supply_register() failed then the orig
Am 07.09.2012 15:38, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip
looks ok to me,
note: i do not have the hardware
Reviewed-by: walter harms
Am 08.09.2012 16:01, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplif
Am 07.10.2012 17:38, schrieb Julia Lawall:
> From: Julia Lawall
>
> Introduce use of I2c_MSG_READ/WRITE/OP, for readability.
>
> In the second i2c_msg structure, a length expressed as an explicit constant
> is also re-expressed as the size of the buffer, reg.
>
> A simplified version of the s
Am 07.10.2012 17:38, schrieb Julia Lawall:
> From: Julia Lawall
>
> Introduce use of I2c_MSG_READ/WRITE/OP, for readability.
>
> A length expressed as an explicit constant is also re-expressed as the size
> of the buffer in each case.
>
> A simplified version of the semantic patch that makes
Am 07.10.2012 18:50, schrieb Julia Lawall:
> On Sun, 7 Oct 2012, walter harms wrote:
>
>>
>>
>> Am 07.10.2012 17:38, schrieb Julia Lawall:
>>> From: Julia Lawall
>>>
>>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability.
>>&g
Am 07.10.2012 18:44, schrieb Julia Lawall:
> On Sun, 7 Oct 2012, walter harms wrote:
>
>>
>>
>> Am 07.10.2012 17:38, schrieb Julia Lawall:
>>> From: Julia Lawall
>>>
>>> Introduce use of I2c_MSG_READ/WRITE/OP, for readability.
>>>
&
Am 02.12.2012 11:44, schrieb Dan Carpenter:
> This is a static checker fix. The problem is that we store the bits
> from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we
> shift it 16 bit to the left. "apicid" is an int so it wraps and we lose
> them.
>
> Signed-off-by: Dan Carp
Hi Cyril,
you patch is correct ..but being an advocate of defensive programming
i would say the original version especially since the number of bytes is small.
re,
wh
Am 05.12.2012 02:22, schrieb Cyril Roelandt:
> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> h
Am 21.04.2013 13:10, schrieb Dan Carpenter:
> The "info.fill" array isn't initialized so it can leak uninitialized
> stack information to user space.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
> index 44d273c..ed5fc43 10064
Am 19.08.2013 10:51, schrieb Julia Lawall:
> From: Julia Lawall
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource_byname when the value is passed to
> devm_ioremap_resource.
>
> A simplified version of the semantic patch that makes this change is as
> follo
Am 19.08.2013 12:12, schrieb Julia Lawall:
> On Mon, 19 Aug 2013, walter harms wrote:
>
>>
>>
>> Am 19.08.2013 10:51, schrieb Julia Lawall:
>>> From: Julia Lawall
>>>
>>> Remove unneeded error handling on the result of a call to
>>&
Hello Julia,
IMHO keep the patch as it is.
It does not change any code that is good.
Suspicious code that comes up here can be addressed
in a separate patch.
just my 2 cents,
re,
wh
Am 05.08.2013 18:19, schrieb Julia Lawall:
> On Mon, 5 Aug 2013, Dan Carpenter wrote:
>
>> On Mon, Aug 05, 2013
Am 10.08.2013 17:32, schrieb Joe Perches:
> On Sat, 2013-08-10 at 17:25 +0200, Julia Lawall wrote:
>> From: Julia Lawall
>>
>> Because ARRAY_AND_SIZE changes the apparent arity of a function, if it is
>> used for one call to a given function, it would be better, if possible, to
>> use it for all
Hello Kumar,
i will try to resolve the riddle ...
doing something like fn(a,b,c,0) is a bad habit.
0 is called a "magic number" because noone reading the code has an idea
why it is there. Using the name IRQF_TRIGGER_NONE good.
Having a named bit like IRQ_TRIGGER|IRQ_NMI is most times also a good
Am 11.08.2013 07:48, schrieb Julia Lawall:
> On Sun, 11 Aug 2013, Dan Carpenter wrote:
>
>> ARRAY_AND_SIZE() macro is horrible, and I would like it if it were
>> removed. What I meant before was just that probably people will
>> probably complain if we try to remove it.
>
> Well, I could eithe
Am 29.05.2013 08:22, schrieb Dan Carpenter:
> I introduced a new temporary variable "info" instead of
> "m->m_info[mds]". Also I reversed the if condition and pulled
> everything in one indent level.
>
> Signed-off-by: Dan Carpenter
> ---
> This goes on top of Emil Goode's patch.
>
> diff --g
it looks ok to me
Reviewed-by: walter harms
Am 14.09.2012 17:13, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
> (http://
Am 16.02.2013 18:56, schrieb Kumar Amit Mehta:
> fix for a potential NULL pointer dereference and removal of a redundant
> assignment operation. Found using smatch.
>
> Signed-off-by: Kumar Amit Mehta
> ---
> drivers/net/ethernet/neterion/vxge/vxge-traffic.c |8 ++--
> 1 file changed,
Am 19.11.2012 22:34, schrieb Cyril Roelandt:
> Found using the following semantic patch:
>
> @@
> @@
> spin_lock_irqsave(...);
> ... when != spin_unlock_irqrestore(...);
> * GFP_KERNEL
>
>
> Signed-off-by: Cyril Roelandt
> ---
> drivers/usb/gadget/uvc_video.c |2 +-
> 1 file changed, 1 i
hello all,
on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21
Using IPI Shortcut mode
WARNING: at block/ll_rw_blk.c:1575 blk_remove_plug()
[] blk_remove_plug+0x36/0x5a
[] __generic_unplug_device+0x14/0x1f
[] __make_request+0x39b/0x49c
[] generic_make_request+0x228/0x255
[]
Satyam Sharma wrote:
> Hi Walter,
>
> Thanks for reporting this.
>
> On 7/22/07, walter harms <[EMAIL PROTECTED]> wrote:
>> hello all,
>> on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21
>
> Did this happen when you were resuming from a
Satyam Sharma wrote:
> On 7/23/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
>> On Sun, Jul 22 2007, Satyam Sharma wrote:
>> > Hi Walter,
>> >
>> > Thanks for reporting this.
>> >
>> > On 7/22/07, walter harms <[EMAIL PROTECTED]>
Jens Axboe wrote:
> On Wed, Jul 25 2007, Satyam Sharma wrote:
>> On 7/23/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
>>> On Sun, Jul 22 2007, Satyam Sharma wrote:
>>>> Hi Walter,
>>>>
>>>> Thanks for reporting this.
>>>>
Jens Axboe wrote:
> On Wed, Jul 25 2007, Satyam Sharma wrote:
>> On 7/23/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
>>> On Sun, Jul 22 2007, Satyam Sharma wrote:
>>>> Hi Walter,
>>>>
>>>> Thanks for reporting this.
>>>>
>>>> On 7/22/07, walter harms <[EMAIL PROTECTED]> wrote:
>>>>> hello all,
>>>>> on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21
>>>> Did this happen when you were resuming from a suspend-to-ram/disk?
>>>&g
hi list,
i managed to crash 2.6.21 at boottime with
IPI Shortcut mode
BUG: atblock/ll_rw_blc.c 1566 blk_remove_plug()
system: acer Notebook TM620
does anyone care or is 2.6.21 already done ?
re,
wh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mess
Am 19.07.2016 20:02, schrieb SF Markus Elfring:
> From: Markus Elfring
> Date: Tue, 19 Jul 2016 19:54:16 +0200
>
> The spi_unregister_device() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by
Am 22.07.2016 17:48, schrieb SF Markus Elfring:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 16:45:22 +0200
>
> Move a return statement into a block for successful function execution.
> Omit a duplicate check for the local variable "ret" then at the end.
>
> Signed-off-by: Markus Elfring
>
Am 29.07.2016 05:55, schrieb Andrew Donnellan:
> Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use
> for_each_child_of_node() rather than a hand-coded for loop.
>
> Remove the useless of_node_put(afu_np) call after the loop, where it's
> guaranteed that afu_np == NULL.
>
> Reported
Am 24.08.2016 22:36, schrieb SF Markus Elfring:
> From: Markus Elfring
> Date: Wed, 24 Aug 2016 22:26:37 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus reuse the corresponding function "kmalloc_ar
perhaps this not tested snipped would make sure that
you have included linux/rose.h ?
#ifndef ROSE_KERNEL_H
#include
#endif
#include
re,
wh
Am 22.08.2016 20:33, schrieb Mikko Rapeli:
> Fixes these userspace compile errors and warnings when glibc
> netrose/rose.h is included before linux/ro
Am 14.10.2017 16:52, schrieb Colin King:
> From: Colin Ian King
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain
Am 16.10.2017 21:04, schrieb Christophe JAILLET:
> Rewrite the exit path based on 'au1200fb_drv_remove()'.
> We can safely iterate for all already handled planes. Even if not
> completely initialized, the functions that are called will silently accept
> the 'fb_info' structure that is passed.
>
Am 01.11.2017 09:49, schrieb Colin King:
> From: Colin Ian King
>
> stat set to zero and the value is never read, instead stat is
> set again in the do-loop. Hence the setting to zero is redundant
> and can be removed. Cleans up clang warning:
>
> drivers/net/wan/wanxl.c:737:2: warning: Value
Am 02.11.2017 15:01, schrieb Colin King:
> From: Colin Ian King
>
> Variable rts is being assigned but it is never read, hence it can be
> removed. The assignment to param_new to zero is redundant as it is
> being updates a few statements later, so remove this redundant
> assignment. Cleans up
Am 02.11.2017 15:22, schrieb Colin Ian King:
> On 02/11/17 14:21, Colin Ian King wrote:
>> On 02/11/17 14:14, walter harms wrote:
>>>
>>>
>>> Am 02.11.2017 15:01, schrieb Colin King:
>>>> From: Colin Ian King
>>>>
>>>&
Am 30.10.2017 11:04, schrieb Michael Kerrisk (man-pages):
> [So, things fell on the floor, a while back.]
>
> On 05/25/2017 11:17 AM, Stas Sergeev wrote:
>> 24.05.2017 14:09, Michael Kerrisk (man-pages) пишет:
>>> One could do this I suppose, but I read POSIX differently from
>>> you and, more i
Am 30.10.2017 11:50, schrieb Michael Kerrisk (man-pages):
> Hi Walter,
>
> On 10/30/2017 11:21 AM, walter harms wrote:
>>
>>
>> Am 30.10.2017 11:04, schrieb Michael Kerrisk (man-pages):
>>> [So, things fell on the floor, a while back.]
>>>
&
Am 30.08.2015 20:05, schrieb Julia Lawall:
> Apply PTR_ERR to the value that was recently assigned.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x,y;
> @@
>
> if (IS_ERR(x) || ...) {
> ... when any
> when != IS_E
Am 30.08.2015 20:05, schrieb Julia Lawall:
> Apply PTR_ERR to the value that was recently assigned.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x,y;
> @@
>
> if (IS_ERR(x) || ...) {
> ... when any
> when != IS_E
From: Colin Ian King
Variable attn is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'attn' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King
---
sound/pci/emu10k1/emupcm.c | 3 +--
1 file changed,
Am 23.01.2018 21:10, schrieb Christopher Díaz Riveros:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Christopher Díaz Riveros
> ---
> drivers/misc/mic/scif/scif_epd.h | 4 +---
> 1 file changed, 1 i
Am 24.01.2018 22:40, schrieb Christopher Díaz Riveros:
> Given the following definitions from s2255drv.c
>
> #define LINE_SZ_4CIFS_NTSC 640
> #define LINE_SZ_2CIFS_NTSC 640
> #define LINE_SZ_1CIFS_NTSC 320
>
> and
>
> #define LINE_SZ_4CIFS_PAL 704
> #define LINE_SZ_2C
Am 13.05.2017 13:40, schrieb Christophe JAILLET:
> This looks spurious to iounmap resources in the normal path of this init
> function.
> The 3 ioremap'ed fields of 'pm_config' can be accessed later on in other
> functions, so it is likely that we should return 'success' before unrolling
> everyt
Am 16.01.2018 11:28, schrieb Colin King:
> From: Colin Ian King
>
> Trivial fix to spelling mistakes in dev_err error message text.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/mtd/nand/marvell_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/
Paolo Ornati wrote:
> On Wed, 22 Aug 2007 23:54:41 -0400
> "Scott Thompson" <[EMAIL PROTECTED]> wrote:
>
>> if anyone knows of a free/inexpensive mail
>> client that will be able to handle the wordwrap requirements for
>> the current state of the linux tree please advise.
>
> http://www.claws
Am 11.06.2015 10:03, schrieb Quentin Lambert:
> The dev_attrs field of struct bus_type is going away, use dev_groups instead.
> This converts the soundbus code to use the correct field.
>
> Given that all other usages of the macro define the struct attribute
> *xxx_attrs[] in the same file they
Hello,
please add a line what is the difference between V1 and V2.
re,
wh
Am 13.06.2015 01:44, schrieb Andy Lutomirski:
> This is only used if BAYCOM_DEBUG is defined.
>
> Cc: Thomas Sailer
> Cc: linux-h...@vger.kernel.org
> Signed-off-by: Andy Lutomirski
> ---
> drivers/net/hamradio/baycom_
Acked-by: walter harms
Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> This is only used if BAYCOM_DEBUG is defined.
>
> Cc: walter harms
> Cc: Ralf Baechle
> Cc: Thomas Sailer
> Cc: linux-h...@vger.kernel.org
> Signed-off-by: Andy Lutomirski
> ---
>
> I'
Am 20.06.2015 18:59, schrieb Julia Lawall:
> !x is more normal for kzalloc failure in the kernel.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x;
> statement S1, S2;
> @@
>
> x = kzalloc(...);
> if (
> - x == NULL
> + !x
thx for info
Von: Christian König
Gesendet: Montag, 8. Februar 2021 13:14:49
An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang
Rui; Junwei Zhang; amd-...@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
Cc: kernel-janit
I second that ...
Having i unsigned violates the rule of "least surprise".
If you need it unsigned make it clearly visible, also adding
a simple comment may help.
jm2c,
wh
Von: Dan Carpenter
Gesendet: Dienstag, 9. Februar 2021 10:19:23
An: Will Deacon
Cc
hi,
thx for you efford,
maybe it is obvious but i did not see it ..
starting with what kernel version are these features available ?
re,
wh
Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im
Auftrag von David Howells [dhowe...@redha
found it,
next i will look for version not varsion
Von: David Howells [dhowe...@redhat.com]
Gesendet: Freitag, 7. August 2020 18:27
An: Walter Harms
Cc: dhowe...@redhat.com; mtk.manpa...@gmail.com; linux-fsde...@vger.kernel.org;
christian.brau
I have learned the other way around:
#include
Is a general system header to use that may include
the asm/prctrl.h what should never be included by
userspace programms.
jm2c,
re,
wh
Von: Alejandro Colomar
Gesendet: Samstag, 13. März 2021 20:25:14
An: mtk.
i am curious:
what is the win to have a unsigned 64 bit integer in the first
place ?
re,
wh
Von: Christian König
Gesendet: Montag, 8. Februar 2021 10:17:42
An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei
Zhang; amd-...@lists.
Hi List,
The ctype macros like isalpha(3) have a locale specific counterpart.
This page was missing.
re,
wh
Signed-off-by: wha...@bfs.de
.\" Copyright (c) 2013 by Walter Harms
.\"
.\" %%%LICENSE_START(VERBATIM)
.\" Permission is granted to make and distribute ver
Am 04.03.2014 22:26, schrieb Peter Senna Tschudin:
> I have reported a bug more than two years ago and it is still
> affecting me. The bug report gives some information:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=787299
>
> I have tried basic debug instructions from:
> https://www.kernel.o
Am 04.04.2014 12:05, schrieb Kumar Amit Mehta:
> Fixed a coding style issue. Reported by checkpatch.pl
>
> Signed-off-by: Kumar Amit Mehta
> ---
> drivers/staging/comedi/drivers/pcl812.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/
Am 21.11.2013 20:12, schrieb Andreas Platschek:
> Use tty_write_lock()/tty_write_unlock() consistently.
>
> This takes care of the following sparse warning:
> drivers/tty/tty_io.c:1169:17: warning: context imbalance in
> 'tty_write_message' - unexpected unlock
>
> Signed-off-by: Andreas Platsc
Am 18.07.2014 17:34, schrieb Andrey Utkin:
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80591
> Reported-by: David Binderman
> Signed-off-by: Andrey Utkin
> ---
> kernel/debug/kdb/kdb_bp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/debug/kdb/kdb
tually can
> overflow 32 bits, so the checks are insufficient.
>
> I have changed it to "> OBD_MAX_IOCTL_BUFFER" instead.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: Updated the error messages as Walter Harms pointed out.
>
> diff --git a/drivers/staging/lu
Am 16.05.2014 11:54, schrieb Emil Goode:
> If we fail to allocate struct platform_device pdev we
> dereference it after the goto label err.
>
> I have rearranged the error handling a bit to fix the issue
> and also make it more clear.
>
> Signed-off-by: Emil Goode
> ---
> v2: Changed to return
Am 16.05.2014 13:16, schrieb Emil Goode:
> Hello Walter,
>
> On Fri, May 16, 2014 at 12:40:19PM +0200, walter harms wrote:
>>
>>
>> Am 16.05.2014 11:54, schrieb Emil Goode:
>>> If we fail to allocate struct platform_device pdev we
>>> dereferenc
Am 19.05.2014 06:31, schrieb Julia Lawall:
> From: Julia Lawall
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.f
Am 19.05.2014 06:31, schrieb Julia Lawall:
> From: Julia Lawall
>
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.f
Am 19.05.2014 13:30, schrieb Julia Lawall:
>
>
> On Mon, 19 May 2014, walter harms wrote:
>
>>
>>
>> Am 19.05.2014 06:31, schrieb Julia Lawall:
>>> From: Julia Lawall
>>>
>>> Delete unnecessary local variable whose value is always
Am 18.05.2014 19:27, schrieb Joe Perches:
> On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote:
>> Remove prohibited space and fix line over 80 characters of
>> memset(...) to meet kernel coding style.
> []
>> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> b/drivers/stag
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
Am 20.05.2014 13:41, schrieb Dan Carpenter:
> Those concerns are valid but the code was like that in the original so
> we should merge this patch as is and hope some volunteer will fix things
> up in a follow on patch.
>
> Fixing them in this patch would be a mistake anyway because of the one
>
Am 26.05.2014 17:21, schrieb Benoit Taine:
> This issue was reported by coccicheck using the semantic patch
> at scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Benoit Taine
> ---
> Tested by compilation without errors.
>
> drivers/misc/vmw_vmci/vmci_datagram.c |3 +--
> 1 file ch
Am 28.05.2014 11:11, schrieb Giedrius Rekasius:
> Local variable "box" gets assigned correct value when it is initialized.
> There is no need to assign the same value again.
>
> Signed-off-by: Giedrius Rekasius
> ---
> arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 -
> 1 file changed, 1 de
Am 31.05.2014 15:14, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
Am 31.05.2014 22:36, schrieb Dan Carpenter:
> On Sat, May 31, 2014 at 10:14:04AM -0300, Peter Senna Tschudin wrote:
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Return the constant instead of using a variab
Am 29.08.2014 10:42, schrieb Dan Carpenter:
> This is untrusted user data from vmci_host_do_send_datagram() so the
> VMCI_DG_SIZE() macro can have an integer overflow.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c
> b/drivers/misc/vmw_vmci/vmci_datagr
Am 05.08.2014 21:49, schrieb David Miller:
> From: walter harms
> Date: Tue, 05 Aug 2014 09:11:52 +0200
>
>>
>>
>> Am 04.08.2014 22:47, schrieb Andrey Utkin:
>>> This commit is a guesswork, but it seems to make sense to drop this
>>> break, as other
Am 06.08.2014 12:39, schrieb Julia Lawall:
> From: Julia Lawall
>
> Delete NULL test on array (always false).
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> @r@
> type T;
> T [] e;
> position p;
> @@
> e ==@p NULL
Am 04.08.2014 22:47, schrieb Andrey Utkin:
> This commit is a guesswork, but it seems to make sense to drop this
> break, as otherwise the following line is never executed and becomes
> dead code. And that following line actually saves the result of
> local calculation by the pointer given in fun
much better readable than the original.
nice work
re,
wh
Am 28.05.2016 06:48, schrieb Dan Carpenter:
> This loop is supposed to set all the .num[] values to -1 but it's off by
> one so it skips the first element and sets one element past the end of
> the array.
>
> I've cleaned up the loop a li
Am 25.02.2016 08:47, schrieb Dan Carpenter:
> It's simpler to just use snprintf() to print this to one buffer instead
> of using strcpy() and strcat(). Also using snprintf() is slightly safer
> than using sprintf().
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/
Am 27.02.2016 11:40, schrieb Dan Carpenter:
> On Sat, Feb 27, 2016 at 10:50:40AM +0100, walter harms wrote:
>>
>>
>> Am 25.02.2016 08:47, schrieb Dan Carpenter:
>>> It's simpler to just use snprintf() to print this to one buffer instead
>>> of using
Am 19.11.2014 13:09, schrieb Dan Carpenter:
> On Wed, Nov 19, 2014 at 12:26:45PM +0100, SF Markus Elfring wrote:
>> --- a/drivers/base/power/wakeup.c
>> +++ b/drivers/base/power/wakeup.c
>> @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev)
>> return -EINVAL;
>>
>>
Am 19.11.2014 14:05, schrieb Dan Carpenter:
> On Wed, Nov 19, 2014 at 01:54:49PM +0100, walter harms wrote:
>> device_wakeup_detach returns dev->power.wakeup what is never NULL in this
>> case.
>> (not visible here but a few line before exactly this is checked)
>
Am 01.12.2014 12:12, schrieb SF Markus Elfring:
> Hello,
>
> Would you like to know how many named function parameters are used in the
> source files?
>
> How do you think about to try the following semantic query approach out a bit
> more?
>
> @initialize:python@
> @@
> import sys
> import
hi Julia,
your patch seems fine.
I tried to understand the code and it seems that much of it
can be simplified by using already available functions.
I have added some comments but i am not sure what to make of it.
re,
wh
Am 01.05.2015 17:51, schrieb Julia Lawall:
> From: Julia Lawall
>
> Repl
1 - 100 of 218 matches
Mail list logo
