[ 07/11] target: Fix double-free of se_cmd in target_complete_tmr_failure
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Nicholas Bellinger commit e13d5fef88c40b87c8430f8274c3a9ca32ef90bc upstream. Fabric drivers currently expect to internally release se_cmd in the event of a TMR failure during target_submit_tmr(), which means the immediate call to transport_generic_free_cmd() after TFO->queue_tm_rsp() from within target_complete_tmr_failure() workqueue context is wrong. This is done as some fabrics expect TMR operations to be acknowledged before releasing the descriptor, so the assumption that core is releasing se_cmd associated TMR memory is incorrect. This fixes a OOPs where transport_generic_free_cmd() was being called more than once. This bug was originally observed with tcm_qla2xxx fabric ports. Signed-off-by: Nicholas Bellinger Cc: Christoph Hellwig Cc: Roland Dreier Cc: Andy Grover Signed-off-by: Greg Kroah-Hartman --- drivers/target/target_core_transport.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -1748,7 +1748,6 @@ static void target_complete_tmr_failure( se_cmd->se_tmr_req->response = TMR_LUN_DOES_NOT_EXIST; se_cmd->se_tfo->queue_tm_rsp(se_cmd); - transport_generic_free_cmd(se_cmd, 0); } /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[ 07/11] target: Fix double-free of se_cmd in target_complete_tmr_failure
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Nicholas Bellinger n...@linux-iscsi.org commit e13d5fef88c40b87c8430f8274c3a9ca32ef90bc upstream. Fabric drivers currently expect to internally release se_cmd in the event of a TMR failure during target_submit_tmr(), which means the immediate call to transport_generic_free_cmd() after TFO-queue_tm_rsp() from within target_complete_tmr_failure() workqueue context is wrong. This is done as some fabrics expect TMR operations to be acknowledged before releasing the descriptor, so the assumption that core is releasing se_cmd associated TMR memory is incorrect. This fixes a OOPs where transport_generic_free_cmd() was being called more than once. This bug was originally observed with tcm_qla2xxx fabric ports. Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Cc: Christoph Hellwig h...@lst.de Cc: Roland Dreier rol...@purestorage.com Cc: Andy Grover agro...@redhat.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/target/target_core_transport.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -1748,7 +1748,6 @@ static void target_complete_tmr_failure( se_cmd-se_tmr_req-response = TMR_LUN_DOES_NOT_EXIST; se_cmd-se_tfo-queue_tm_rsp(se_cmd); - transport_generic_free_cmd(se_cmd, 0); } /** -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
