Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 7:27 AM Paolo Bonzini wrote: > > > Well, being in linux-next should have found it too. I know linux-next > > had a lot of kvm stuff in it, was this not there? > > It was, I suppose that's how Arnd found it. Ok, apparently the 0day bot doesn't trigger this case, or it's

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 7:27 AM Paolo Bonzini wrote: > > > Well, being in linux-next should have found it too. I know linux-next > > had a lot of kvm stuff in it, was this not there? > > It was, I suppose that's how Arnd found it. Ok, apparently the 0day bot doesn't trigger this case, or it's

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:56, Linus Torvalds wrote: > On Wed, Jun 13, 2018 at 3:09 AM Paolo Bonzini wrote: >> >> On 13/06/2018 04:18, Linus Torvalds wrote: >>> >>> Hmm? And why was this not found before it hit my tree? >> >> Because I should do more "make randconfig"s, probably. > > Well, being in

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:56, Linus Torvalds wrote: > On Wed, Jun 13, 2018 at 3:09 AM Paolo Bonzini wrote: >> >> On 13/06/2018 04:18, Linus Torvalds wrote: >>> >>> Hmm? And why was this not found before it hit my tree? >> >> Because I should do more "make randconfig"s, probably. > > Well, being in

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 4:00 AM Vitaly Kuznetsov wrote: > > This was reported before by Arnd Bergmann: > > https://www.spinics.net/lists/kvm/msg169536.html > > but it seems his patch got lost. So I think his patch is closer to what the code *should* do. Mine was a big ugly #if around the whole

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 4:00 AM Vitaly Kuznetsov wrote: > > This was reported before by Arnd Bergmann: > > https://www.spinics.net/lists/kvm/msg169536.html > > but it seems his patch got lost. So I think his patch is closer to what the code *should* do. Mine was a big ugly #if around the whole

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 3:09 AM Paolo Bonzini wrote: > > On 13/06/2018 04:18, Linus Torvalds wrote: > > > > Hmm? And why was this not found before it hit my tree? > > Because I should do more "make randconfig"s, probably. Well, being in linux-next should have found it too. I know linux-next had

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Linus Torvalds
On Wed, Jun 13, 2018 at 3:09 AM Paolo Bonzini wrote: > > On 13/06/2018 04:18, Linus Torvalds wrote: > > > > Hmm? And why was this not found before it hit my tree? > > Because I should do more "make randconfig"s, probably. Well, being in linux-next should have found it too. I know linux-next had

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Dave Martin
On Tue, Jun 12, 2018 at 07:43:50PM +0100, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > Grr. Several tedious conflicts. I fixed them all up, and they all > looked trivial, but since most of

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Dave Martin
On Tue, Jun 12, 2018 at 07:43:50PM +0100, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > Grr. Several tedious conflicts. I fixed them all up, and they all > looked trivial, but since most of

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 13/06/2018 04:18, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: >>> >>> * x86: many bugfixes, implement more Hyper-V super powers, >> >> Uhhuh, I didn't notice this initially, because my basic sanity tests >> are with everything

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 13/06/2018 04:18, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: >>> >>> * x86: many bugfixes, implement more Hyper-V super powers, >> >> Uhhuh, I didn't notice this initially, because my basic sanity tests >> are with everything

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 04:18, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: >> >> * x86: many bugfixes, implement more Hyper-V super powers, > > Uhhuh, I didn't notice this initially, because my basic sanity tests > are with everything enabled, but this breaks the build: >

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 04:18, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: >> >> * x86: many bugfixes, implement more Hyper-V super powers, > > Uhhuh, I didn't notice this initially, because my basic sanity tests > are with everything enabled, but this breaks the build: >

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Wanpeng Li
On Wed, 13 Jun 2018 at 12:53, Linus Torvalds wrote: > > On Tue, Jun 12, 2018 at 9:49 PM Greg Kroah-Hartman > wrote: > I'm going to be start traveling towards Japan and China tomorrow > morning, so I wanted to just get the problems I noticed out of my Great!, welcome to our country(China), and

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-13 Thread Wanpeng Li
On Wed, 13 Jun 2018 at 12:53, Linus Torvalds wrote: > > On Tue, Jun 12, 2018 at 9:49 PM Greg Kroah-Hartman > wrote: > I'm going to be start traveling towards Japan and China tomorrow > morning, so I wanted to just get the problems I noticed out of my Great!, welcome to our country(China), and

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 9:49 PM Greg Kroah-Hartman wrote: > > The revert is fine, I'll work on the kvm debugfs file stuff for 4.19. Yeah, I did two fairly brute-force fixes for two different issues (the only common thread was kvm - testing the first fix was what then got me to the debugfs

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 9:49 PM Greg Kroah-Hartman wrote: > > The revert is fine, I'll work on the kvm debugfs file stuff for 4.19. Yeah, I did two fairly brute-force fixes for two different issues (the only common thread was kvm - testing the first fix was what then got me to the debugfs

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 12, 2018 at 08:52:08PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds > wrote: > > > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > > > The commit looks

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 12, 2018 at 08:52:08PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds > wrote: > > > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > > > The commit looks

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 12, 2018 at 08:26:46PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:00 PM Linus Torvalds > wrote: > > > > Yeah, the biusection seems to actually be diving into Greg's device pulls. > > > > Odd. I'm not seeing why that would break kvm, but maybe there's > > something in the

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Greg Kroah-Hartman
On Tue, Jun 12, 2018 at 08:26:46PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:00 PM Linus Torvalds > wrote: > > > > Yeah, the biusection seems to actually be diving into Greg's device pulls. > > > > Odd. I'm not seeing why that would break kvm, but maybe there's > > something in the

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds wrote: > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > The commit looks like the RightThing(tm) to do, but we do not break > existing work-flows, no

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds wrote: > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > The commit looks like the RightThing(tm) to do, but we do not break > existing work-flows, no

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 8:00 PM Linus Torvalds wrote: > > Yeah, the biusection seems to actually be diving into Greg's device pulls. > > Odd. I'm not seeing why that would break kvm, but maybe there's > something in the device core layer that really messed it up. > > I'll continue to bisect to

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 8:00 PM Linus Torvalds wrote: > > Yeah, the biusection seems to actually be diving into Greg's device pulls. > > Odd. I'm not seeing why that would break kvm, but maybe there's > something in the device core layer that really messed it up. > > I'll continue to bisect to

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:51 PM Wanpeng Li wrote: > > > > Bisecting. But that's unrelated to the recent kvm build breakage. > > Yeah, it happens before the KVM GIT PULL on Linus's tree, you will see > the warning above unless you lauch the guest w/ root user, maybe other > subsystems'

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:51 PM Wanpeng Li wrote: > > > > Bisecting. But that's unrelated to the recent kvm build breakage. > > Yeah, it happens before the KVM GIT PULL on Linus's tree, you will see > the warning above unless you lauch the guest w/ root user, maybe other > subsystems'

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Wanpeng Li
On Wed, 13 Jun 2018 at 10:42, Linus Torvalds wrote: > > On Tue, Jun 12, 2018 at 7:18 PM Linus Torvalds > wrote: > > > > The attached patch _may_ be the right thing to do. It's not pretty. > > .. and when I decided to actually do some minimal kvm testing with > that patch, I notice that we've

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Wanpeng Li
On Wed, 13 Jun 2018 at 10:42, Linus Torvalds wrote: > > On Tue, Jun 12, 2018 at 7:18 PM Linus Torvalds > wrote: > > > > The attached patch _may_ be the right thing to do. It's not pretty. > > .. and when I decided to actually do some minimal kvm testing with > that patch, I notice that we've

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:18 PM Linus Torvalds wrote: > > The attached patch _may_ be the right thing to do. It's not pretty. .. and when I decided to actually do some minimal kvm testing with that patch, I notice that we've apparently broken kvm entirely during this merge window, and I just get

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:18 PM Linus Torvalds wrote: > > The attached patch _may_ be the right thing to do. It's not pretty. .. and when I decided to actually do some minimal kvm testing with that patch, I notice that we've apparently broken kvm entirely during this merge window, and I just get

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > * x86: many bugfixes, implement more Hyper-V super powers, Uhhuh, I didn't notice this initially, because my basic sanity tests are with everything enabled, but this breaks the build: ERROR: "ms_hyperv" [arch/x86/kvm/kvm-intel.ko]

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > * x86: many bugfixes, implement more Hyper-V super powers, Uhhuh, I didn't notice this initially, because my basic sanity tests are with everything enabled, but this breaks the build: ERROR: "ms_hyperv" [arch/x86/kvm/kvm-intel.ko]

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus Grr. Several tedious conflicts. I fixed them all up, and they all looked trivial, but since most of them were to ARM cases, I couldn't even test the end result. I suspect the

Re: [GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 7:03 AM Paolo Bonzini wrote: > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus Grr. Several tedious conflicts. I fixed them all up, and they all looked trivial, but since most of them were to ARM cases, I couldn't even test the end result. I suspect the

[GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Paolo Bonzini
Linus, The following changes since commit 73fcb1a370c76b202d406e95d9dabb76eaccf484: Merge branch 'akpm' (patches from Andrew) (2018-05-18 21:24:26 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to

[GIT PULL] KVM changes for 4.18 merge window

2018-06-12 Thread Paolo Bonzini
Linus, The following changes since commit 73fcb1a370c76b202d406e95d9dabb76eaccf484: Merge branch 'akpm' (patches from Andrew) (2018-05-18 21:24:26 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to