Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 10:02, Michel Lespinasse wrote: > On Fri, Apr 26, 2013 at 1:49 AM, Matt Fleming wrote: >> On 26/04/13 08:43, Michel Lespinasse wrote: >>> Still seeing the crash. >>> >>> I went and compared the crash dump with the vmlinux disassembly; the >>> issue is a NULL pointer dereference in

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 08:29, Ingo Molnar wrote: > I'm worried about the fragility of this code - this is firmware code ... > > I think firmware code should be fundamentally paranoid and robust, and in > this case treat all EFI-provided data as hostile and do a much sanity > checking of it as possible -

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Michel Lespinasse
On Fri, Apr 26, 2013 at 1:49 AM, Matt Fleming wrote: > On 26/04/13 08:43, Michel Lespinasse wrote: >> Still seeing the crash. >> >> I went and compared the crash dump with the vmlinux disassembly; the >> issue is a NULL pointer dereference in list_for_each_entry_safe(). >> list_empty() checks

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 08:43, Michel Lespinasse wrote: > Still seeing the crash. > > I went and compared the crash dump with the vmlinux disassembly; the > issue is a NULL pointer dereference in list_for_each_entry_safe(). > list_empty() checks that the head node points to itself, but here the > head node

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Michel Lespinasse
On Fri, Apr 26, 2013 at 12:12 AM, Matt Fleming wrote: > On 26/04/13 00:11, Michel Lespinasse wrote: >> On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin wrote: >>> On 04/25/2013 03:53 PM, Michel Lespinasse wrote: Well, I don't know if this is related, but commit e971318bbed6 broke the

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Ingo Molnar
* Matthew Garrett wrote: > On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: > > On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin > > wrote: > > > > > > - if (!sys_table->runtime->query_variable_info) > > > + if (sys_table->runtime->hdr.revision < > > >

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 00:11, Michel Lespinasse wrote: > On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin wrote: >> On 04/25/2013 03:53 PM, Michel Lespinasse wrote: >>> On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett >>> wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: > On Thu, Apr

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 00:11, Michel Lespinasse wrote: On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin h...@zytor.com wrote: On 04/25/2013 03:53 PM, Michel Lespinasse wrote: On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Ingo Molnar
* Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin h...@linux.intel.com wrote: - if (!sys_table-runtime-query_variable_info) + if (sys_table-runtime-hdr.revision

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Michel Lespinasse
On Fri, Apr 26, 2013 at 12:12 AM, Matt Fleming matt.flem...@intel.com wrote: On 26/04/13 00:11, Michel Lespinasse wrote: On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin h...@zytor.com wrote: On 04/25/2013 03:53 PM, Michel Lespinasse wrote: Well, I don't know if this is related, but commit

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 08:43, Michel Lespinasse wrote: Still seeing the crash. I went and compared the crash dump with the vmlinux disassembly; the issue is a NULL pointer dereference in list_for_each_entry_safe(). list_empty() checks that the head node points to itself, but here the head node has

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 08:29, Ingo Molnar wrote: I'm worried about the fragility of this code - this is firmware code ... I think firmware code should be fundamentally paranoid and robust, and in this case treat all EFI-provided data as hostile and do a much sanity checking of it as possible - and

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Michel Lespinasse
On Fri, Apr 26, 2013 at 1:49 AM, Matt Fleming matt.flem...@intel.com wrote: On 26/04/13 08:43, Michel Lespinasse wrote: Still seeing the crash. I went and compared the crash dump with the vmlinux disassembly; the issue is a NULL pointer dereference in list_for_each_entry_safe(). list_empty()

Re: [GIT PULL] x86 fixes for 3.9

2013-04-26 Thread Matt Fleming
On 26/04/13 10:02, Michel Lespinasse wrote: On Fri, Apr 26, 2013 at 1:49 AM, Matt Fleming matt.flem...@intel.com wrote: On 26/04/13 08:43, Michel Lespinasse wrote: Still seeing the crash. I went and compared the crash dump with the vmlinux disassembly; the issue is a NULL pointer dereference

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Michel Lespinasse
On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin wrote: > On 04/25/2013 03:53 PM, Michel Lespinasse wrote: >> On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett >> wrote: >>> On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin wrote:

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread H. Peter Anvin
On 04/25/2013 03:53 PM, Michel Lespinasse wrote: > On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett > wrote: >> On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: >>> On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin >>> wrote: - if (!sys_table->runtime->query_variable_info)

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Michel Lespinasse
On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett wrote: > On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: >> On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin wrote: >> > >> > - if (!sys_table->runtime->query_variable_info) >> > + if (sys_table->runtime->hdr.revision < >> >

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Matthew Garrett
On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: > On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin wrote: > > > > - if (!sys_table->runtime->query_variable_info) > > + if (sys_table->runtime->hdr.revision < > > EFI_2_00_SYSTEM_TABLE_REVISION) > > return

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Linus Torvalds
On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin wrote: > > - if (!sys_table->runtime->query_variable_info) > + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) > return EFI_UNSUPPORTED; Is a EFI 2.00 system table *guaranteed* to have that

[GIT PULL] x86 fixes for 3.9

2013-04-25 Thread H. Peter Anvin
Hi Linus, The following changes since commit 0fbd06761f5c17cc9b20e02af60fd7ee9c895996: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc (2013-04-24 17:10:18 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

[GIT PULL] x86 fixes for 3.9

2013-04-25 Thread H. Peter Anvin
Hi Linus, The following changes since commit 0fbd06761f5c17cc9b20e02af60fd7ee9c895996: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc (2013-04-24 17:10:18 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Linus Torvalds
On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin h...@linux.intel.com wrote: - if (!sys_table-runtime-query_variable_info) + if (sys_table-runtime-hdr.revision EFI_2_00_SYSTEM_TABLE_REVISION) return EFI_UNSUPPORTED; Is a EFI 2.00 system table *guaranteed* to have

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Matthew Garrett
On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin h...@linux.intel.com wrote: - if (!sys_table-runtime-query_variable_info) + if (sys_table-runtime-hdr.revision EFI_2_00_SYSTEM_TABLE_REVISION) return

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Michel Lespinasse
On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin h...@linux.intel.com wrote: - if (!sys_table-runtime-query_variable_info) + if

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread H. Peter Anvin
On 04/25/2013 03:53 PM, Michel Lespinasse wrote: On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin h...@linux.intel.com wrote: - if

Re: [GIT PULL] x86 fixes for 3.9

2013-04-25 Thread Michel Lespinasse
On Thu, Apr 25, 2013 at 3:54 PM, H. Peter Anvin h...@zytor.com wrote: On 04/25/2013 03:53 PM, Michel Lespinasse wrote: On Thu, Apr 25, 2013 at 3:23 PM, Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote: On Thu, Apr 25, 2013 at 2:44 PM,

[GIT PULL] x86 fixes for 3.9-rc4

2013-03-23 Thread H. Peter Anvin
Hi Linus, A collection of minor fixes, more EFI variables paranoia (anti-bricking) plus the ability to disable the pstore either as a runtime default or completely, due to bricking concerns. The following changes since commit a937536b868b8369b98967929045f1df54234323: Linux 3.9-rc3 (2013-03-17

[GIT PULL] x86 fixes for 3.9-rc4

2013-03-23 Thread H. Peter Anvin
Hi Linus, A collection of minor fixes, more EFI variables paranoia (anti-bricking) plus the ability to disable the pstore either as a runtime default or completely, due to bricking concerns. The following changes since commit a937536b868b8369b98967929045f1df54234323: Linux 3.9-rc3 (2013-03-17