Re: [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr

[Rafael J. Wysocki]

On Friday, February 9, 2018 7:08:21 PM CET Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1465078
> Signed-off-by: Gustavo A. R. Silva 
> ---
> This code was compiled with GCC 7.3.0
> 
>  drivers/acpi/spcr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index 89e97d2..9d52743 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool 
> enable_console)
>   table->serial_port.access_width))) {
>   default:
>   pr_err("Unexpected SPCR Access Width.  Defaulting to 
> byte size\n");
> + /* fall through */
>   case 8:
>   iotype = "mmio";
>   break;
> 

Applied, thanks!

Re: [PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr

[Rafael J. Wysocki]

On Friday, February 9, 2018 7:08:21 PM CET Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1465078
> Signed-off-by: Gustavo A. R. Silva 
> ---
> This code was compiled with GCC 7.3.0
> 
>  drivers/acpi/spcr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index 89e97d2..9d52743 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool 
> enable_console)
>   table->serial_port.access_width))) {
>   default:
>   pr_err("Unexpected SPCR Access Width.  Defaulting to 
> byte size\n");
> + /* fall through */
>   case 8:
>   iotype = "mmio";
>   break;
> 

Applied, thanks!

[PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1465078
Signed-off-by: Gustavo A. R. Silva 
---
This code was compiled with GCC 7.3.0

 drivers/acpi/spcr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 89e97d2..9d52743 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool 
enable_console)
table->serial_port.access_width))) {
default:
pr_err("Unexpected SPCR Access Width.  Defaulting to 
byte size\n");
+   /* fall through */
case 8:
iotype = "mmio";
break;
-- 
2.7.4

[PATCH] ACPI: SPCR: Mark expected switch fall-through in acpi_parse_spcr

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1465078
Signed-off-by: Gustavo A. R. Silva 
---
This code was compiled with GCC 7.3.0

 drivers/acpi/spcr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 89e97d2..9d52743 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -115,6 +115,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool 
enable_console)
table->serial_port.access_width))) {
default:
pr_err("Unexpected SPCR Access Width.  Defaulting to 
byte size\n");
+   /* fall through */
case 8:
iotype = "mmio";
break;
-- 
2.7.4