Re: [PATCH] ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()

[Takashi Iwai]

On Sat, 12 Aug 2017 19:15:58 +0200,
SF Markus Elfring wrote:
> 
> From: Markus Elfring 
> Date: Sat, 12 Aug 2017 19:09:23 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Applied, thanks.


Takashi

Re: [PATCH] ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()

[Takashi Iwai]

On Sat, 12 Aug 2017 19:15:58 +0200,
SF Markus Elfring wrote:
> 
> From: Markus Elfring 
> Date: Sat, 12 Aug 2017 19:09:23 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 

Applied, thanks.


Takashi

[PATCH] ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 12 Aug 2017 19:09:23 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 sound/pci/ca0106/ca0106_main.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index 6165a57a94ae..b7783137af04 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -660,11 +660,9 @@ static int snd_ca0106_pcm_open_capture_channel(struct 
snd_pcm_substream *substre
int err;
 
epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
-   if (epcm == NULL) {
-   dev_err(chip->card->dev,
-   "open_capture_channel: failed epcm alloc\n");
+   if (!epcm)
return -ENOMEM;
-}
+
epcm->emu = chip;
epcm->substream = substream;
 epcm->channel_id=channel_id;
-- 
2.14.0

[PATCH] ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 12 Aug 2017 19:09:23 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 sound/pci/ca0106/ca0106_main.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index 6165a57a94ae..b7783137af04 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -660,11 +660,9 @@ static int snd_ca0106_pcm_open_capture_channel(struct 
snd_pcm_substream *substre
int err;
 
epcm = kzalloc(sizeof(*epcm), GFP_KERNEL);
-   if (epcm == NULL) {
-   dev_err(chip->card->dev,
-   "open_capture_channel: failed epcm alloc\n");
+   if (!epcm)
return -ENOMEM;
-}
+
epcm->emu = chip;
epcm->substream = substream;
 epcm->channel_id=channel_id;
-- 
2.14.0