Re: [PATCH] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

2017-08-10 Thread Sylwester Nawrocki
On 08/10/2017 05:56 PM, Anton Vasilyev wrote: If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() permorms pri_dai->sec_dai dereference in any case. s/permorms/performs The patch adds sec_dai check on N

[PATCH] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

2017-08-10 Thread Anton Vasilyev
If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() permorms pri_dai->sec_dai dereference in any case. The patch adds sec_dai check on Null before derefence at samsung_i2s_remove(). Found by Linux Driver Ve