Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-16 Thread Jason Gunthorpe
On Mon, Apr 16, 2018 at 01:56:20AM -0700, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 04:02:12AM +, Greg Thelen wrote: > > I think I've identified the set of options which use > > INFINIBAND_ADDR_TRANS without a kconfig depends: > > * CIFS_SMB_DIRECT > > * INFINIBAND_SRPT > > * NVME_RDMA

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-16 Thread oulijun
在 2018/4/13 20:47, Bart Van Assche 写道: > On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote: >> Allow INFINIBAND without INFINIBAND_ADDR_TRANS. >> >> Signed-off-by: Greg Thelen >> Cc: Tarick Bedeir >> --- >> drivers/infiniband/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-16 Thread Christoph Hellwig
On Mon, Apr 16, 2018 at 04:02:12AM +, Greg Thelen wrote: > I think I've identified the set of options which use > INFINIBAND_ADDR_TRANS without a kconfig depends: > * CIFS_SMB_DIRECT > * INFINIBAND_SRPT > * NVME_RDMA > * NVME_TARGET_RDMA > > I have patches for the above, but need to finish the

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-15 Thread Greg Thelen
On Sun, Apr 15, 2018 at 5:06 AM Christoph Hellwig wrote: > On Fri, Apr 13, 2018 at 12:06:44AM -0700, Greg Thelen wrote: > > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. > Why? We are pushing everyone heavily to use RDMA/CM, so making it > optional seems rather counter-intuitive. Bugs. We d

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-15 Thread Christoph Hellwig
On Fri, Apr 13, 2018 at 12:06:44AM -0700, Greg Thelen wrote: > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. Why? We are pushing everyone heavily to use RDMA/CM, so making it optional seems rather counter-intuitive. You'll also have to fix tons of ULPs to explicitly depend on INFINIBAND_ADDR_T

Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-13 Thread Bart Van Assche
On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote: > Allow INFINIBAND without INFINIBAND_ADDR_TRANS. > > Signed-off-by: Greg Thelen > Cc: Tarick Bedeir > --- > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/Kconfig b/dr

[PATCH] IB: make INFINIBAND_ADDR_TRANS configurable

2018-04-13 Thread Greg Thelen
Allow INFINIBAND without INFINIBAND_ADDR_TRANS. Signed-off-by: Greg Thelen Cc: Tarick Bedeir --- drivers/infiniband/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index ee270e065ba9..f20a3977087c 100644 --- a/d