RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-10-03 Thread Dexuan Cui
> From: dmitry.torok...@gmail.com > Sent: Thursday, October 3, 2019 10:46 AM > > > > I think I understood now: it looks the vmbus driver should implement > > a prepare() or freeze(), which calls the hyperv_keyboard driver's > > prepare() or freeze(), which can set the flag or disable the keyboard

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-10-03 Thread dmitry.torok...@gmail.com
On Thu, Oct 03, 2019 at 06:44:04AM +, Dexuan Cui wrote: > > From: Dexuan Cui > > Sent: Wednesday, October 2, 2019 10:35 PM > > > ... > > > > > > ¯\_(ツ)_/¯ If you do not want to implement hibernation properly in vmbus > > > code that is totally up to you (have you read in pm.h how freeze() is

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-10-03 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, October 2, 2019 10:35 PM > > ... > > > > ¯\_(ツ)_/¯ If you do not want to implement hibernation properly in vmbus > > code that is totally up to you (have you read in pm.h how freeze() is > > different from suspend()?). > > Dmitry > > I understand freeze() is

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-10-02 Thread Dexuan Cui
> From: dmitry.torok...@gmail.com > Sent: Monday, September 30, 2019 4:07 PM > > On Mon, Sep 30, 2019 at 10:09:27PM +, Dexuan Cui wrote: > > > From: dmitry.torok...@gmail.com > > > Sent: Friday, September 27, 2019 5:32 PM > > > > ... > > > > pm_wakeup_pending() is tested in a lot of places

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-30 Thread dmitry.torok...@gmail.com
On Mon, Sep 30, 2019 at 10:09:27PM +, Dexuan Cui wrote: > > From: dmitry.torok...@gmail.com > > Sent: Friday, September 27, 2019 5:32 PM > > > ... > > > pm_wakeup_pending() is tested in a lot of places in the suspend > > > process and eventually an unintentional keystroke (or mouse movement,

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-30 Thread Dexuan Cui
> From: dmitry.torok...@gmail.com > Sent: Friday, September 27, 2019 5:32 PM > > ... > > pm_wakeup_pending() is tested in a lot of places in the suspend > > process and eventually an unintentional keystroke (or mouse movement, > > when it comes to the Hyper-V mouse driver

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-27 Thread dmitry.torok...@gmail.com
On Sat, Sep 21, 2019 at 06:56:04AM +, Dexuan Cui wrote: > > From: dmitry.torok...@gmail.com > > Sent: Thursday, September 19, 2019 9:18 AM > > > > Hi Dexuan, > > > > On Wed, Sep 11, 2019 at 11:36:20PM +, Dexuan Cui wrote: > > > We need hv_kbd_pm_notify() to make sure the

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
vger.kernel.org; > linux-kernel@vger.kernel.org; Michael Kelley > Subject: RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation > > > From: dmitry.torok...@gmail.com > > Sent: Thursday, September 19, 2019 9:18 AM > > > > Hi Dexuan, > > > >

RE: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-21 Thread Dexuan Cui
> From: dmitry.torok...@gmail.com > Sent: Thursday, September 19, 2019 9:18 AM > > Hi Dexuan, > > On Wed, Sep 11, 2019 at 11:36:20PM +, Dexuan Cui wrote: > > We need hv_kbd_pm_notify() to make sure the pm_wakeup_hard_event() > call > > does not prevent the system from entering hibernation:

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-19 Thread dmitry.torok...@gmail.com
Hi Dexuan, On Wed, Sep 11, 2019 at 11:36:20PM +, Dexuan Cui wrote: > We need hv_kbd_pm_notify() to make sure the pm_wakeup_hard_event() call > does not prevent the system from entering hibernation: the hibernation > is a relatively long process, which can be aborted by the call >

[PATCH] Input: hyperv-keyboard: Add the support of hibernation

2019-09-11 Thread Dexuan Cui
We need hv_kbd_pm_notify() to make sure the pm_wakeup_hard_event() call does not prevent the system from entering hibernation: the hibernation is a relatively long process, which can be aborted by the call pm_wakeup_hard_event(), which is invoked upon keyboard events. Signed-off-by: Dexuan Cui