Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 23:42, Radim Krcmar wrote: > > 2018-08-29 13:29+0300, Dan Carpenter: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > > wrote: > > > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 23:42, Radim Krcmar wrote: > > 2018-08-29 13:29+0300, Dan Carpenter: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > > wrote: > > > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 13:29+0300, Dan Carpenter: > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > wrote: > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 13:29+0300, Dan Carpenter: > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > wrote: > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 15:55+0200, Radim Krcmar: > 2018-08-29 13:43+0300, Liran Alon: > > Why is “min” defined as “int” instead of “unsigned int”? > > It represents the lowest APIC ID in bitmap so it can’t be negative… > > Right, > > I think the code would look better as something like (untested): > > diff

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 15:55+0200, Radim Krcmar: > 2018-08-29 13:43+0300, Liran Alon: > > Why is “min” defined as “int” instead of “unsigned int”? > > It represents the lowest APIC ID in bitmap so it can’t be negative… > > Right, > > I think the code would look better as something like (untested): > > diff

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 13:43+0300, Liran Alon: > Why is “min” defined as “int” instead of “unsigned int”? > It represents the lowest APIC ID in bitmap so it can’t be negative… Right, I think the code would look better as something like (untested): diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Radim Krcmar
2018-08-29 13:43+0300, Liran Alon: > Why is “min” defined as “int” instead of “unsigned int”? > It represents the lowest APIC ID in bitmap so it can’t be negative… Right, I think the code would look better as something like (untested): diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 06:42:42PM +0800, Wanpeng Li wrote: > On Wed, 29 Aug 2018 at 18:29, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > > wrote: > > > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 06:42:42PM +0800, Wanpeng Li wrote: > On Wed, 29 Aug 2018 at 18:29, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > > wrote: > > > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Liran Alon
> On 29 Aug 2018, at 13:29, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: >> On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: >>> >>> On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Liran Alon
> On 29 Aug 2018, at 13:29, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: >> On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: >>> >>> On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 18:29, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > wrote: > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 12:05:06PM

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 18:29, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter > > wrote: > > > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 12:05:06PM

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > > > arch/x86/kvm/lapic.c | 17

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 06:23:08PM +0800, Wanpeng Li wrote: > On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: > > > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > > > arch/x86/kvm/lapic.c | 17

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > > arch/x86/kvm/lapic.c | 17 + > > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > >

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Wanpeng Li
On Wed, 29 Aug 2018 at 18:18, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > > arch/x86/kvm/lapic.c | 17 + > > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > >

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > arch/x86/kvm/lapic.c | 17 + > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/x86/kvm/lapic.c

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 01:12:05PM +0300, Dan Carpenter wrote: > On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > > arch/x86/kvm/lapic.c | 17 + > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/x86/kvm/lapic.c

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > arch/x86/kvm/lapic.c | 17 + > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > > index 0cefba2..86e933c 100644 > > --- a/arch/x86/kvm/lapic.c > >

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Dan Carpenter
On Wed, Aug 29, 2018 at 12:05:06PM +0300, Liran Alon wrote: > > arch/x86/kvm/lapic.c | 17 + > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > > index 0cefba2..86e933c 100644 > > --- a/arch/x86/kvm/lapic.c > >

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Liran Alon
> On 29 Aug 2018, at 8:52, Wanpeng Li wrote: > > From: Wanpeng Li > > Dan Carpenter reported that the untrusted data returns from > kvm_register_read() > results in the following static checker warning: > arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() > error: buffer underflow

Re: [PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-29 Thread Liran Alon
> On 29 Aug 2018, at 8:52, Wanpeng Li wrote: > > From: Wanpeng Li > > Dan Carpenter reported that the untrusted data returns from > kvm_register_read() > results in the following static checker warning: > arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() > error: buffer underflow

[PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-28 Thread Wanpeng Li
From: Wanpeng Li Dan Carpenter reported that the untrusted data returns from kvm_register_read() results in the following static checker warning: arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() error: buffer underflow 'map->phys_map' 's32min-s32max' KVM guest can easily trigger this by executing

[PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-28 Thread Wanpeng Li
From: Wanpeng Li Dan Carpenter reported that the untrusted data returns from kvm_register_read() results in the following static checker warning: arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() error: buffer underflow 'map->phys_map' 's32min-s32max' KVM guest can easily trigger this by executing

[PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-28 Thread Wanpeng Li
From: Wanpeng Li Dan Carpenter reported that the untrusted data returns from kvm_register_read() results in the following static checker warning: arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() error: buffer underflow 'map->phys_map' 's32min-s32max' KVM guest can easily trigger this by executing

[PATCH] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-28 Thread Wanpeng Li
From: Wanpeng Li Dan Carpenter reported that the untrusted data returns from kvm_register_read() results in the following static checker warning: arch/x86/kvm/lapic.c:576 kvm_pv_send_ipi() error: buffer underflow 'map->phys_map' 's32min-s32max' KVM guest can easily trigger this by executing