Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[James Hogan]

On Thu, Feb 22, 2018 at 10:10:30AM -0800, David Daney wrote:
> On 02/22/2018 10:08 AM, Colin King wrote:
> > From: Colin Ian King 
> > 
> > The allocation of host_data is not null checked, leading to a
> > null pointer dereference if the allocation fails. Fix this by
> > adding a null check and return with -ENOMEM.
> > 
> > Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
> > Signed-off-by: Colin Ian King 
> 
> Acked-by: David Daney 

Applied to my fixes branch with 4.0+ stable tag.

Thanks
James


signature.asc
Description: Digital signature

Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[James Hogan]

On Thu, Feb 22, 2018 at 10:10:30AM -0800, David Daney wrote:
> On 02/22/2018 10:08 AM, Colin King wrote:
> > From: Colin Ian King 
> > 
> > The allocation of host_data is not null checked, leading to a
> > null pointer dereference if the allocation fails. Fix this by
> > adding a null check and return with -ENOMEM.
> > 
> > Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
> > Signed-off-by: Colin Ian King 
> 
> Acked-by: David Daney 

Applied to my fixes branch with 4.0+ stable tag.

Thanks
James


signature.asc
Description: Digital signature

Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[David Daney]

On 02/22/2018 10:08 AM, Colin King wrote:

From: Colin Ian King 

The allocation of host_data is not null checked, leading to a
null pointer dereference if the allocation fails. Fix this by
adding a null check and return with -ENOMEM.

Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King 


Acked-by: David Daney 



---
  arch/mips/cavium-octeon/octeon-irq.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c 
b/arch/mips/cavium-octeon/octeon-irq.c
index b993d9f2c9b9..203e1d2a56d5 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(struct device_node 
*ciu_node,
}
  
  	host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);

+   if (!host_data)
+   return -ENOMEM;
raw_spin_lock_init(_data->lock);
  
  	addr = of_get_address(ciu_node, 0, NULL, NULL);

Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[David Daney]

On 02/22/2018 10:08 AM, Colin King wrote:

From: Colin Ian King 

The allocation of host_data is not null checked, leading to a
null pointer dereference if the allocation fails. Fix this by
adding a null check and return with -ENOMEM.

Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King 


Acked-by: David Daney 



---
  arch/mips/cavium-octeon/octeon-irq.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c 
b/arch/mips/cavium-octeon/octeon-irq.c
index b993d9f2c9b9..203e1d2a56d5 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(struct device_node 
*ciu_node,
}
  
  	host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);

+   if (!host_data)
+   return -ENOMEM;
raw_spin_lock_init(_data->lock);
  
  	addr = of_get_address(ciu_node, 0, NULL, NULL);

[PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[Colin King]

From: Colin Ian King 

The allocation of host_data is not null checked, leading to a
null pointer dereference if the allocation fails. Fix this by
adding a null check and return with -ENOMEM.

Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King 
---
 arch/mips/cavium-octeon/octeon-irq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c 
b/arch/mips/cavium-octeon/octeon-irq.c
index b993d9f2c9b9..203e1d2a56d5 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(struct device_node 
*ciu_node,
}
 
host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
+   if (!host_data)
+   return -ENOMEM;
raw_spin_lock_init(_data->lock);
 
addr = of_get_address(ciu_node, 0, NULL, NULL);
-- 
2.15.1

[PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

[Colin King]

From: Colin Ian King 

The allocation of host_data is not null checked, leading to a
null pointer dereference if the allocation fails. Fix this by
adding a null check and return with -ENOMEM.

Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King 
---
 arch/mips/cavium-octeon/octeon-irq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c 
b/arch/mips/cavium-octeon/octeon-irq.c
index b993d9f2c9b9..203e1d2a56d5 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(struct device_node 
*ciu_node,
}
 
host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
+   if (!host_data)
+   return -ENOMEM;
raw_spin_lock_init(_data->lock);
 
addr = of_get_address(ciu_node, 0, NULL, NULL);
-- 
2.15.1