Re: [PATCH] Omnikey Cardman 4040 driver (UPDATE)

2005-09-06 Thread Harald Welte
Hi hch, thanks for your feedback. An updated version of the patch is at the bottom of this mail. On Mon, Sep 05, 2005 at 08:06:35PM +0100, Christoph Hellwig wrote: > > +#include > > I don't think you need this one. done > > +#include > > you shouldn't need this one. done > > +static

Re: [PATCH] Omnikey Cardman 4040 driver (UPDATE)

2005-09-06 Thread Harald Welte
Hi hch, thanks for your feedback. An updated version of the patch is at the bottom of this mail. On Mon, Sep 05, 2005 at 08:06:35PM +0100, Christoph Hellwig wrote: +#include linux/version.h I don't think you need this one. done +#include pcmcia/version.h you shouldn't need this one.

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Jesper Juhl
On Monday 05 September 2005 22:05, Jesper Juhl wrote: > On Monday 05 September 2005 21:54, Harald Welte wrote: > > Hi! > > > > I've now incorporated all the suggested changes (thanks once again on > > the many comments received). The resulting driver has been tested and > > works fine. > > > >

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Jesper Juhl
On Monday 05 September 2005 21:54, Harald Welte wrote: > Hi! > > I've now incorporated all the suggested changes (thanks once again on > the many comments received). The resulting driver has been tested and > works fine. > > Please consider applying the driver to the mainline tree, thanks. >

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Christoph Hellwig
> +#include I don't think you need this one. > +#include you shouldn't need this one. > +static atomic_t cm4040_num_devices_open; > + > +#ifdef PCMCIA_DEBUG > +static int pc_debug = PCMCIA_DEBUG; > +module_param(pc_debug, int, 0600); > +#define DEBUG(n, x, args...) do { if (pc_debug >= (n))

[PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Harald Welte
Hi! I've now incorporated all the suggested changes (thanks once again on the many comments received). The resulting driver has been tested and works fine. Please consider applying the driver to the mainline tree, thanks.

[PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Harald Welte
Hi! I've now incorporated all the suggested changes (thanks once again on the many comments received). The resulting driver has been tested and works fine. Please consider applying the driver to the mainline tree, thanks.

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Christoph Hellwig
+#include linux/version.h I don't think you need this one. +#include pcmcia/version.h you shouldn't need this one. +static atomic_t cm4040_num_devices_open; + +#ifdef PCMCIA_DEBUG +static int pc_debug = PCMCIA_DEBUG; +module_param(pc_debug, int, 0600); +#define DEBUG(n, x, args...) do

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Jesper Juhl
On Monday 05 September 2005 21:54, Harald Welte wrote: Hi! I've now incorporated all the suggested changes (thanks once again on the many comments received). The resulting driver has been tested and works fine. Please consider applying the driver to the mainline tree, thanks. What did

Re: [PATCH] Omnikey Cardman 4040 driver

2005-09-05 Thread Jesper Juhl
On Monday 05 September 2005 22:05, Jesper Juhl wrote: On Monday 05 September 2005 21:54, Harald Welte wrote: Hi! I've now incorporated all the suggested changes (thanks once again on the many comments received). The resulting driver has been tested and works fine. Please consider