RE: Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe()

2018-02-21 Thread MyungJoo Ham 
> On 2018년 02월 14일 06:17, SF Markus Elfring wrote:
> > From: Markus Elfring 
> > Date: Tue, 13 Feb 2018 22:10:42 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring 
> > ---
> >  drivers/devfreq/event/exynos-ppmu.c | 6 ++
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c 
> > b/drivers/devfreq/event/exynos-ppmu.c
> > index d96e3dc71cf8..72ac9113500d 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device 
> > *pdev)
> >  
> > size = sizeof(struct devfreq_event_dev *) * info->num_events;
> > info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
> > -   if (!info->edev) {
> > -   dev_err(&pdev->dev,
> > -   "failed to allocate memory devfreq-event devices\n");
> > +   if (!info->edev)
> > return -ENOMEM;
> > -   }
> > +
> > edev = info->edev;
> > platform_set_drvdata(pdev, info);
> >  
> > 
> 
> Acked-by: Chanwoo Choi 
> 

Acked-by: MyungJoo Ham

Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe()

2018-02-13 Thread Chanwoo Choi 
On 2018년 02월 14일 06:17, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Tue, 13 Feb 2018 22:10:42 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---
>  drivers/devfreq/event/exynos-ppmu.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c 
> b/drivers/devfreq/event/exynos-ppmu.c
> index d96e3dc71cf8..72ac9113500d 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device 
> *pdev)
>  
>   size = sizeof(struct devfreq_event_dev *) * info->num_events;
>   info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
> - if (!info->edev) {
> - dev_err(&pdev->dev,
> - "failed to allocate memory devfreq-event devices\n");
> + if (!info->edev)
>   return -ENOMEM;
> - }
> +
>   edev = info->edev;
>   platform_set_drvdata(pdev, info);
>  
> 

Acked-by: Chanwoo Choi 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe()

2018-02-13 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Tue, 13 Feb 2018 22:10:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/devfreq/event/exynos-ppmu.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c 
b/drivers/devfreq/event/exynos-ppmu.c
index d96e3dc71cf8..72ac9113500d 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
 
size = sizeof(struct devfreq_event_dev *) * info->num_events;
info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
-   if (!info->edev) {
-   dev_err(&pdev->dev,
-   "failed to allocate memory devfreq-event devices\n");
+   if (!info->edev)
return -ENOMEM;
-   }
+
edev = info->edev;
platform_set_drvdata(pdev, info);
 
-- 
2.16.1