Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-23 Thread Tony Lindgren
* Andy Shevchenko [180214 10:24]: > Subject: [PATCH] genirq: Add wakeup sysfs node to show IRQ wakeup state > > Surprisingly there is no simple way to see if the IRQ line in question > is wakeup source or not. Finally got around trying this one. Yeah it's nice and it seems that this is how we co

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-20 Thread Rafael J. Wysocki
On Friday, February 16, 2018 3:52:22 PM CET Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 12:54 PM, Rafael J. Wysocki wrote: > > On Fri, Feb 16, 2018 at 11:39 AM, Andy Shevchenko > > wrote: > >> On Fri, Feb 16, 2018 at 11:14 AM, Rafael J. Wysocki > >> wrote: > >>> On Wed, Feb 14, 2018 at 12:

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Tony Lindgren
* Andy Shevchenko [180216 10:40]: > Sorry, I was thinking that Tony may test it first to see if it does > what he wants. Well using dev_name() for the wakeirq name might still conflict with the device IO interrupt. But yeah I'll give it a try. Regards, Tony

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Tony Lindgren
* Rafael J. Wysocki [180216 09:42]: > On Fri, Feb 9, 2018 at 5:14 PM, Tony Lindgren wrote: > > This makes it easy to grep :wakeup /proc/interrupts. > > diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c > > --- a/drivers/base/power/wakeirq.c > > +++ b/drivers/base/power/wake

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Andy Shevchenko
On Fri, Feb 16, 2018 at 12:54 PM, Rafael J. Wysocki wrote: > On Fri, Feb 16, 2018 at 11:39 AM, Andy Shevchenko > wrote: >> On Fri, Feb 16, 2018 at 11:14 AM, Rafael J. Wysocki >> wrote: >>> On Wed, Feb 14, 2018 at 12:23 PM, Andy Shevchenko >>> wrote: >>> IMO it is somewhat excessive to put the

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Rafael J. Wysocki
On Fri, Feb 16, 2018 at 11:39 AM, Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 11:14 AM, Rafael J. Wysocki wrote: >> On Wed, Feb 14, 2018 at 12:23 PM, Andy Shevchenko >> wrote: >>> On Fri, Feb 9, 2018 at 6:14 PM, Tony Lindgren wrote: This makes it easy to grep :wakeup /proc/interrupts.

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Andy Shevchenko
On Fri, Feb 16, 2018 at 11:14 AM, Rafael J. Wysocki wrote: > On Wed, Feb 14, 2018 at 12:23 PM, Andy Shevchenko > wrote: >> On Fri, Feb 9, 2018 at 6:14 PM, Tony Lindgren wrote: >>> This makes it easy to grep :wakeup /proc/interrupts. >> >> I used to have another patch (not published) to provide t

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Rafael J. Wysocki
On Fri, Feb 9, 2018 at 5:14 PM, Tony Lindgren wrote: > This makes it easy to grep :wakeup /proc/interrupts. > > Cc: Brian Norris > Cc: Grygorii Strashko > Cc: Ulf Hansson > Suggested-by: Jeffy Chen > Signed-off-by: Tony Lindgren > --- > drivers/base/power/power.h | 1 + > drivers/base/pow

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-16 Thread Rafael J. Wysocki
On Wed, Feb 14, 2018 at 12:23 PM, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 6:14 PM, Tony Lindgren wrote: >> This makes it easy to grep :wakeup /proc/interrupts. > > I used to have another patch (not published) to provide this > information via /sys/kernel/irq. > > OK, here we are: > > >> +

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-14 Thread Andy Shevchenko
On Fri, Feb 9, 2018 at 6:14 PM, Tony Lindgren wrote: > This makes it easy to grep :wakeup /proc/interrupts. I used to have another patch (not published) to provide this information via /sys/kernel/irq. OK, here we are: > + namelen = strlen(dev_name(dev)) + strlen(postfix) + 1; > +

Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-14 Thread Rafael J. Wysocki
On Friday, February 9, 2018 5:14:56 PM CET Tony Lindgren wrote: > This makes it easy to grep :wakeup /proc/interrupts. > > Cc: Brian Norris > Cc: Grygorii Strashko > Cc: Ulf Hansson > Suggested-by: Jeffy Chen > Signed-off-by: Tony Lindgren > --- > drivers/base/power/power.h | 1 + > drive

[PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

2018-02-09 Thread Tony Lindgren
This makes it easy to grep :wakeup /proc/interrupts. Cc: Brian Norris Cc: Grygorii Strashko Cc: Ulf Hansson Suggested-by: Jeffy Chen Signed-off-by: Tony Lindgren --- drivers/base/power/power.h | 1 + drivers/base/power/wakeirq.c | 18 +++--- 2 files changed, 16 insertions(+),