Re: [PATCH] RFC: bus: fix semicolon.cocci warnings
On Fri, 2018-06-15 at 19:59 +0200, Julia Lawall wrote: > From: kbuild test robot > > Remove unneeded semicolon. [] > +++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c > @@ -223,7 +223,7 @@ out_unreg_leds: > platform_device_unregister(sec->leds_device); > for (i = 0; i < ARRAY_SIZE(ledinfos); i++) { > mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod); > - }; > + } > return ERR_PTR(ret); > } > EXPORT_SYMBOL_GPL(secure96_populate); > @@ -244,6 +244,6 @@ void secure96_depopulate(void *data) > platform_device_unregister(sec->leds_device); > for (i = 0; i < ARRAY_SIZE(ledinfos); i++) { > mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod); > - }; > + } > } > EXPORT_SYMBOL_GPL(secure96_depopulate); While these are clearly correct, perhaps it would be better to remove the braces too.
[PATCH] RFC: bus: fix semicolon.cocci warnings
From: kbuild test robot Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git ultra96 head: 27803f286226e1b5b5893aabfd55feec08b73bae commit: 7d8c3a62781bbd8b42119b3af2c90f4d9eef3748 [20/21] RFC: bus: 96boards Low-Speed Connector 96boards-secure96.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/bus/96boards-mezzanines/96boards-secure96.c +++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c @@ -223,7 +223,7 @@ out_unreg_leds: platform_device_unregister(sec->leds_device); for (i = 0; i < ARRAY_SIZE(ledinfos); i++) { mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod); - }; + } return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(secure96_populate); @@ -244,6 +244,6 @@ void secure96_depopulate(void *data) platform_device_unregister(sec->leds_device); for (i = 0; i < ARRAY_SIZE(ledinfos); i++) { mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod); - }; + } } EXPORT_SYMBOL_GPL(secure96_depopulate);