Hi,Tyler,
Yes, I will add a patch based on it, thanks a lot that you will also have a
test.
On 2017/8/14 22:04, Baicar, Tyler wrote:
> This change works too, I think it just makes sense to have the iterations in
> the CPER and GHES code match. Do you want to add a patch to your patch here
>
On 8/11/2017 5:41 PM, gengdongjiu wrote:
2017-08-11 21:19 GMT+08:00 Baicar, Tyler :
I removed the apei_estatus_for_each_section because it was only being used
in this one spot even though several other parts of the code do the same
iteration (it is done several times in the CPER code). I made th
2017-08-11 21:19 GMT+08:00 Baicar, Tyler :
> I removed the apei_estatus_for_each_section because it was only being used
> in this one spot even though several other parts of the code do the same
> iteration (it is done several times in the CPER code). I made this iteration
> match the CPER iteratio
I removed the apei_estatus_for_each_section because it was only being
used in this one spot even though several other parts of the code do the
same iteration (it is done several times in the CPER code). I made this
iteration match the CPER iterations because the CPER iterations are
verifying th
may be directly remove the macro apei_estatus_for_each_section is not better,
if other place code also
needs to iterate through the GHES estatus blocks, it will be repeated written
again.
On 2017/8/11 5:31, gengdongjiu wrote:
> Hello,
>
>sorry, I do not see that. Just know I have reviewed
Hello,
sorry, I do not see that. Just know I have reviewed your modification, may
be my change can be simpleness and reserve the macro of
apei_estatus_for_each_section
can be used by other place to avoid duplicated code, such as prints the estatus
blocks.
On 2017/8/11 1:48, Baicar, Tyler wr
Hello,
I have already posted a patch fixing this. Please see:
https://lkml.org/lkml/2017/8/3/824
This makes the loop identical to the CPER code which prints the estatus
blocks to the kernel logs.
Thanks,
Tyler
On 8/10/2017 12:06 PM, Dongjiu Geng wrote:
The revision 0x300 generic error da
The revision 0x300 generic error data entry is different with the old
version. when ghes_do_proc traverses to get the data entry, it does not
consider this difference. so when error status block has revision 0x300
data entry, it will have issue.
Signed-off-by: Dongjiu Geng
---
drivers/acpi/apei/
8 matches
Mail list logo
