Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
On Tue, Aug 20, 2019 at 05:06:29PM +0100, Mark Rutland wrote: > On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: > > It would be worth having a body for the commit message like: > > | in perf_event.c we use smp_processor_id(), but we haven't included > | where it is defined, and rely on this being pulled in > | via a transitive include. Let's make this more robust by including > | explciitly. > > ... and with that, my Acked-by stands. Queued for 5.4. with typo fixed above. Will
Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: It would be worth having a body for the commit message like: | in perf_event.c we use smp_processor_id(), but we haven't included | where it is defined, and rely on this being pulled in | via a transitive include. Let's make this more robust by including | explciitly. ... and with that, my Acked-by stands. Thanks, Mark. > Acked-by: Mark Rutland > Signed-off-by: Raphael Gault > --- > arch/arm64/kernel/perf_event.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c > index 96e90e270042..24575c0a0065 100644 > --- a/arch/arm64/kernel/perf_event.c > +++ b/arch/arm64/kernel/perf_event.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > /* ARMv8 Cortex-A53 specific event types. */ > #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2 > -- > 2.17.1 >
[PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
Acked-by: Mark Rutland Signed-off-by: Raphael Gault --- arch/arm64/kernel/perf_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 96e90e270042..24575c0a0065 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64/kernel/perf_event.c @@ -19,6 +19,7 @@ #include #include #include +#include /* ARMv8 Cortex-A53 specific event types. */ #define ARMV8_A53_PERFCTR_PREF_LINEFILL0xC2 -- 2.17.1
