Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

2016-09-21 Thread Stephen Boyd 
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav 
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav 
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

2016-09-20 Thread James Liao 
On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote:
> From: Arvind Yadav 
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav 

Reviewed-by: James Liao 

> ---
>  drivers/clk/mediatek/clk-mt8173.c |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c 
> b/drivers/clk/mediatek/clk-mt8173.c
> index 10c9860..0ac3aee 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct 
> device_node *node)
>   }
>  
>   mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> - if (!clk_data)
> + if (!clk_data) {
> + iounmap(base);
>   return;
> + }
>  
>   mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
>

[PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap

2016-09-20 Thread Arvind Yadav 
From: Arvind Yadav 

Free memory mapping, if init is not successful.

Signed-off-by: Arvind Yadav 
---
 drivers/clk/mediatek/clk-mt8173.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mt8173.c 
b/drivers/clk/mediatek/clk-mt8173.c
index 10c9860..0ac3aee 100644
--- a/drivers/clk/mediatek/clk-mt8173.c
+++ b/drivers/clk/mediatek/clk-mt8173.c
@@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct 
device_node *node)
}
 
mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
-   if (!clk_data)
+   if (!clk_data) {
+   iounmap(base);
return;
+   }
 
mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
 
-- 
1.7.9.5