[PATCH] drivers/char/synclink.c: check kmalloc() return value.

[Amit Choudhary]

Description: Check the return value of kmalloc() in function 
mgsl_alloc_intermediate_txbuffer_memory(), in file drivers/char/synclink.c.

Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]>

diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
index 06784ad..24f99bc 100644
--- a/drivers/char/synclink.c
+++ b/drivers/char/synclink.c
@@ -4012,8 +4012,13 @@ static int mgsl_alloc_intermediate_txbuf
for ( i=0; inum_tx_holding_buffers; ++i) {
info->tx_holding_buffers[i].buffer =
kmalloc(info->max_frame_size, GFP_KERNEL);
-   if ( info->tx_holding_buffers[i].buffer == NULL )
+   if (info->tx_holding_buffers[i].buffer == NULL) {
+   for (--i; i >= 0; i--) {
+   kfree(info->tx_holding_buffers[i].buffer);
+   info->tx_holding_buffers[i].buffer = NULL;
+   }
return -ENOMEM;
+   }
}
 
return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] drivers/char/synclink.c: check kmalloc() return value.

[Amit Choudhary]

Description: Check the return value of kmalloc() in function 
mgsl_alloc_intermediate_txbuffer_memory(), in file drivers/char/synclink.c.

Signed-off-by: Amit Choudhary [EMAIL PROTECTED]

diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
index 06784ad..24f99bc 100644
--- a/drivers/char/synclink.c
+++ b/drivers/char/synclink.c
@@ -4012,8 +4012,13 @@ static int mgsl_alloc_intermediate_txbuf
for ( i=0; iinfo-num_tx_holding_buffers; ++i) {
info-tx_holding_buffers[i].buffer =
kmalloc(info-max_frame_size, GFP_KERNEL);
-   if ( info-tx_holding_buffers[i].buffer == NULL )
+   if (info-tx_holding_buffers[i].buffer == NULL) {
+   for (--i; i = 0; i--) {
+   kfree(info-tx_holding_buffers[i].buffer);
+   info-tx_holding_buffers[i].buffer = NULL;
+   }
return -ENOMEM;
+   }
}
 
return 0;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/