Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Felipe Balbi
Hi, Greg KH writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du &

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Felipe Balbi
Hi, Greg KH writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du & 0xff cannot be true when du

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Greg KH
On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: > Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > > The condition modex % 16 cannot be true when modex value is equal to > > 640 > > The condition du & 0xff cannot be true when du value is equal to > > 0x1400 >

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Greg KH
On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: > Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > > The condition modex % 16 cannot be true when modex value is equal to > > 640 > > The condition du & 0xff cannot be true when du value is equal to > > 0x1400 >

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Oliver Neukum
Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > The condition modex % 16 cannot be true when modex value is equal to > 640 > The condition du & 0xff cannot be true when du value is equal to > 0x1400 >  Sorry for speaking up so late, but this is not a good idea. We lose the

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-16 Thread Oliver Neukum
Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > The condition modex % 16 cannot be true when modex value is equal to > 640 > The condition du & 0xff cannot be true when du value is equal to > 0x1400 >  Sorry for speaking up so late, but this is not a good idea. We lose the

[PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-07 Thread Gustavo A. R. Silva
The condition modex % 16 cannot be true when modex value is equal to 640 The condition du & 0xff cannot be true when du value is equal to 0x1400 Addresses-Coverity-Id: 101163 Addresses-Coverity-Id: 744373 Signed-off-by: Gustavo A. R. Silva ---

[PATCH] drivers: usb-misc: sisusbvga: remove dead code

2017-02-07 Thread Gustavo A. R. Silva
The condition modex % 16 cannot be true when modex value is equal to 640 The condition du & 0xff cannot be true when du value is equal to 0x1400 Addresses-Coverity-Id: 101163 Addresses-Coverity-Id: 744373 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/sisusbvga/sisusb.c | 6 -- 1