Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-26 Thread Gerd Hoffmann 
On Mo, 2016-09-26 at 11:29 +0200, Daniel Vetter wrote:
> On Mon, Sep 26, 2016 at 10:52 AM, Gerd Hoffmann  wrote:
> > On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
> >> -int bochs_connector_get_modes(struct drm_connector *connector)
> >> +static int bochs_connector_get_modes(struct drm_connector *connector)
> >
> > Added to drm-qemu queue.
> 
> I've thrown this one already into drm-misc, and it's wrapped up in my
> latest pull to Dave already.
> -Daniel

Ah, cool, so I don't need an additional drm-qemu pull req.

thanks,
  Gerd

Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-26 Thread Daniel Vetter 
On Mon, Sep 26, 2016 at 10:52 AM, Gerd Hoffmann  wrote:
> On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
>> -int bochs_connector_get_modes(struct drm_connector *connector)
>> +static int bochs_connector_get_modes(struct drm_connector *connector)
>
> Added to drm-qemu queue.

I've thrown this one already into drm-misc, and it's wrapped up in my
latest pull to Dave already.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-26 Thread Gerd Hoffmann 
On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote:
> -int bochs_connector_get_modes(struct drm_connector *connector)
> +static int bochs_connector_get_modes(struct drm_connector *connector)

Added to drm-qemu queue.

thanks,
  Gerd

[PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-25 Thread Baoyou Xie 
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/bochs/bochs_kms.c:181:5: warning: no previous prototype for 
'bochs_connector_get_modes' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie 
---
 drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bochs/bochs_kms.c 
b/drivers/gpu/drm/bochs/bochs_kms.c
index 207a2cb..0b4e5d1 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -178,7 +178,7 @@ static void bochs_encoder_init(struct drm_device *dev)
 }
 
 
-int bochs_connector_get_modes(struct drm_connector *connector)
+static int bochs_connector_get_modes(struct drm_connector *connector)
 {
int count;
 
-- 
2.7.4

[PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-18 Thread Baoyou Xie 
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/bochs/bochs_kms.c:181:5: warning: no previous prototype for 
'bochs_connector_get_modes' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie 
---
 drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bochs/bochs_kms.c 
b/drivers/gpu/drm/bochs/bochs_kms.c
index 207a2cb..0b4e5d1 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -178,7 +178,7 @@ static void bochs_encoder_init(struct drm_device *dev)
 }
 
 
-int bochs_connector_get_modes(struct drm_connector *connector)
+static int bochs_connector_get_modes(struct drm_connector *connector)
 {
int count;
 
-- 
2.7.4