Re: [PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
> 
> Signed-off-by: Sudip Mukherjee 
> ---
Hi Ben,
A gentle ping.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
> 
> Signed-off-by: Sudip Mukherjee 
> ---
Hi Ben,
A gentle ping.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
> 
> Signed-off-by: Sudip Mukherjee 
> ---
A gentle ping.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
> 
> Signed-off-by: Sudip Mukherjee 
> ---
A gentle ping.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

coverity.com reported that memset was using a buffer of size 0, on
checking the code it turned out that the function was not being used. So
remove it.

Signed-off-by: Sudip Mukherjee 
---
 drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h |  2 --
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c | 13 -
 2 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h 
b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
index d606875..3a643df 100644
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
@@ -4,8 +4,6 @@ struct nvbios_pmuT {
 };
 
 u32 nvbios_pmuTe(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len);
-u32 nvbios_pmuTp(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
-struct nvbios_pmuT *);
 
 struct nvbios_pmuE {
u8  type;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
index 441ec45..c268e5a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
@@ -62,19 +62,6 @@ nvbios_pmuTe(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 
*cnt, u8 *len)
 }
 
 u32
-nvbios_pmuTp(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
-struct nvbios_pmuT *info)
-{
-   u32 data = nvbios_pmuTe(bios, ver, hdr, cnt, len);
-   memset(info, 0x00, sizeof(*info));
-   switch (!!data * *ver) {
-   default:
-   break;
-   }
-   return data;
-}
-
-u32
 nvbios_pmuEe(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr)
 {
u8  cnt, len;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] drm/nouveau: remove unused function

[Sudip Mukherjee]

coverity.com reported that memset was using a buffer of size 0, on
checking the code it turned out that the function was not being used. So
remove it.

Signed-off-by: Sudip Mukherjee 
---
 drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h |  2 --
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c | 13 -
 2 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h 
b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
index d606875..3a643df 100644
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
@@ -4,8 +4,6 @@ struct nvbios_pmuT {
 };
 
 u32 nvbios_pmuTe(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len);
-u32 nvbios_pmuTp(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
-struct nvbios_pmuT *);
 
 struct nvbios_pmuE {
u8  type;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
index 441ec45..c268e5a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
@@ -62,19 +62,6 @@ nvbios_pmuTe(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 
*cnt, u8 *len)
 }
 
 u32
-nvbios_pmuTp(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
-struct nvbios_pmuT *info)
-{
-   u32 data = nvbios_pmuTe(bios, ver, hdr, cnt, len);
-   memset(info, 0x00, sizeof(*info));
-   switch (!!data * *ver) {
-   default:
-   break;
-   }
-   return data;
-}
-
-u32
 nvbios_pmuEe(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr)
 {
u8  cnt, len;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/