Re: [PATCH] ecryptfs: remove private bin2hex implementation

2016-10-10 Thread Tyler Hicks
On 09/20/2016 06:17 PM, Rasmus Villemoes wrote: > Calling sprintf in a loop is not very efficient, and in any case, we > already have an implementation of bin-to-hex conversion in lib/ which > we might as well use. > > Note that ecryptfs_to_hex used to nul-terminate the destination (and > the

Re: [PATCH] ecryptfs: remove private bin2hex implementation

2016-10-10 Thread Tyler Hicks
On 09/20/2016 06:17 PM, Rasmus Villemoes wrote: > Calling sprintf in a loop is not very efficient, and in any case, we > already have an implementation of bin-to-hex conversion in lib/ which > we might as well use. > > Note that ecryptfs_to_hex used to nul-terminate the destination (and > the

[PATCH] ecryptfs: remove private bin2hex implementation

2016-09-20 Thread Rasmus Villemoes
Calling sprintf in a loop is not very efficient, and in any case, we already have an implementation of bin-to-hex conversion in lib/ which we might as well use. Note that ecryptfs_to_hex used to nul-terminate the destination (and the kernel doc was wrong about the required output size), while

[PATCH] ecryptfs: remove private bin2hex implementation

2016-09-20 Thread Rasmus Villemoes
Calling sprintf in a loop is not very efficient, and in any case, we already have an implementation of bin-to-hex conversion in lib/ which we might as well use. Note that ecryptfs_to_hex used to nul-terminate the destination (and the kernel doc was wrong about the required output size), while