Re: [PATCH] enic: fix boolreturn.cocci warnings

[David Miller]

From: kbuild test robot 
Date: Wed, 7 Mar 2018 02:23:23 +0800

> From: Fengguang Wu 
> 
> drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 
> in function 'vnic_dev_capable_udp_rss' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 48398b6e7065 ("enic: set UDP rss flag")
> CC: Govindarajulu Varadarajan 
> Signed-off-by: Fengguang Wu 

Applied to net-next.

Re: [PATCH] enic: fix boolreturn.cocci warnings

[David Miller]

From: kbuild test robot 
Date: Wed, 7 Mar 2018 02:23:23 +0800

> From: Fengguang Wu 
> 
> drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 
> in function 'vnic_dev_capable_udp_rss' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 48398b6e7065 ("enic: set UDP rss flag")
> CC: Govindarajulu Varadarajan 
> Signed-off-by: Fengguang Wu 

Applied to net-next.

[PATCH] enic: fix boolreturn.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in 
function 'vnic_dev_capable_udp_rss' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan 
Signed-off-by: Fengguang Wu 
---

 vnic_dev.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni
 
err = vnic_dev_cmd(vdev, CMD_CAPABILITY, , , wait);
if (err || !a0)
-   return 0;
+   return false;
 
rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;

[PATCH] enic: fix boolreturn.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in 
function 'vnic_dev_capable_udp_rss' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan 
Signed-off-by: Fengguang Wu 
---

 vnic_dev.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni
 
err = vnic_dev_cmd(vdev, CMD_CAPABILITY, , , wait);
if (err || !a0)
-   return 0;
+   return false;
 
rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;