Re: [PATCH] gpio: f7188x: use gpiochip_get_data instead of container_of

2016-09-18 Thread Linus Walleij 
On Fri, Sep 16, 2016 at 6:58 PM, Amitesh Singh  wrote:

> gpiochip_add_data is already used to add data pointer and chip.
> Lets rely on gpiochip_get_data which is getting used in other
> gpio_chip functions.
>
> Signed-off-by: Amitesh Singh 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH] gpio: f7188x: use gpiochip_get_data instead of container_of

2016-09-18 Thread Linus Walleij 
On Fri, Sep 16, 2016 at 6:58 PM, Amitesh Singh  wrote:

> gpiochip_add_data is already used to add data pointer and chip.
> Lets rely on gpiochip_get_data which is getting used in other
> gpio_chip functions.
>
> Signed-off-by: Amitesh Singh 

Patch applied.

Yours,
Linus Walleij

[PATCH] gpio: f7188x: use gpiochip_get_data instead of container_of

2016-09-16 Thread Amitesh Singh 
gpiochip_add_data is already used to add data pointer and chip.
Lets rely on gpiochip_get_data which is getting used in other
gpio_chip functions.

Signed-off-by: Amitesh Singh 
---
 drivers/gpio/gpio-f7188x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index 600be84..e8accde 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -214,8 +214,7 @@ static struct f7188x_gpio_bank f81866_gpio_bank[] = {
 static int f7188x_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
 {
int err;
-   struct f7188x_gpio_bank *bank =
-   container_of(chip, struct f7188x_gpio_bank, chip);
+   struct f7188x_gpio_bank *bank = gpiochip_get_data(chip);
struct f7188x_sio *sio = bank->data->sio;
u8 dir;
 
-- 
2.7.4

[PATCH] gpio: f7188x: use gpiochip_get_data instead of container_of

2016-09-16 Thread Amitesh Singh 
gpiochip_add_data is already used to add data pointer and chip.
Lets rely on gpiochip_get_data which is getting used in other
gpio_chip functions.

Signed-off-by: Amitesh Singh 
---
 drivers/gpio/gpio-f7188x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index 600be84..e8accde 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -214,8 +214,7 @@ static struct f7188x_gpio_bank f81866_gpio_bank[] = {
 static int f7188x_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
 {
int err;
-   struct f7188x_gpio_bank *bank =
-   container_of(chip, struct f7188x_gpio_bank, chip);
+   struct f7188x_gpio_bank *bank = gpiochip_get_data(chip);
struct f7188x_sio *sio = bank->data->sio;
u8 dir;
 
-- 
2.7.4