Re: [PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Thomas Gleixner wrote: > > /me pleads guilty ! > > Replacement patch below. Well, I already applied the original one that came through Andrew, so I really just wanted to note the coding style in general, and your fixed patch no longer applied ;) Also, you do end up

[PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Thomas Gleixner
On Tue, 2007-03-06 at 08:44 -0800, Linus Torvalds wrote: > This is just a coding style thing, but I thought I should really point it > out, because these kinds of things quite often result in nasty bugs simply > because the source code is so hard to read properly: /me pleads guilty !

[PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Thomas Gleixner
On Tue, 2007-03-06 at 08:44 -0800, Linus Torvalds wrote: This is just a coding style thing, but I thought I should really point it out, because these kinds of things quite often result in nasty bugs simply because the source code is so hard to read properly: /me pleads guilty ! Replacement

Re: [PATCH] highres: do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, Thomas Gleixner wrote: /me pleads guilty ! Replacement patch below. Well, I already applied the original one that came through Andrew, so I really just wanted to note the coding style in general, and your fixed patch no longer applied ;) Also, you do end up testing

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-05 Thread Ingo Molnar
* Andres Salomon <[EMAIL PROTECTED]> wrote: > >> And an additional request, just to make it explicit that we should > >> not have any NO_SOFTIRQ callbacks in the tree; BUG out if we > >> encounter such a thing. > > > > please change it to WARN_ON_ONCE()... > > > > 'bug out' might mean: 'dead

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-05 Thread Ingo Molnar
* Andres Salomon [EMAIL PROTECTED] wrote: And an additional request, just to make it explicit that we should not have any NO_SOFTIRQ callbacks in the tree; BUG out if we encounter such a thing. please change it to WARN_ON_ONCE()... 'bug out' might mean: 'dead box'/'no

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Andres Salomon
Ingo Molnar wrote: > * Andres Salomon <[EMAIL PROTECTED]> wrote: > >> Thomas Gleixner wrote: > The question is, how the tick timer gets enqueued in the softirq queue. > Can you isolate the codepath, where this happens ? >>> The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Ingo Molnar
* Andres Salomon <[EMAIL PROTECTED]> wrote: > Thomas Gleixner wrote: > >>> The question is, how the tick timer gets enqueued in the softirq queue. > >>> Can you isolate the codepath, where this happens ? > > > > The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable > > clocksource

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Thomas Gleixner
On Sun, 2007-03-04 at 08:12 -0500, Andres Salomon wrote: > Thomas Gleixner wrote: > >>> The question is, how the tick timer gets enqueued in the softirq queue. > >>> Can you isolate the codepath, where this happens ? > > > > The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable > >

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Andres Salomon
Thomas Gleixner wrote: >>> The question is, how the tick timer gets enqueued in the softirq queue. >>> Can you isolate the codepath, where this happens ? > > The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable > clocksource and clock event sources are registered. The switch to high >

[PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Thomas Gleixner
> > The question is, how the tick timer gets enqueued in the softirq queue. > > Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and clock event sources are registered. The switch to high resolution mode happens inside

[PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Thomas Gleixner
The question is, how the tick timer gets enqueued in the softirq queue. Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and clock event sources are registered. The switch to high resolution mode happens inside of

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Andres Salomon
Thomas Gleixner wrote: The question is, how the tick timer gets enqueued in the softirq queue. Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and clock event sources are registered. The switch to high

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Thomas Gleixner
On Sun, 2007-03-04 at 08:12 -0500, Andres Salomon wrote: Thomas Gleixner wrote: The question is, how the tick timer gets enqueued in the softirq queue. Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Ingo Molnar
* Andres Salomon [EMAIL PROTECTED] wrote: Thomas Gleixner wrote: The question is, how the tick timer gets enqueued in the softirq queue. Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and clock event

Re: [PATCH] highres: Do not run the TIMER_SOFTIRQ after switching to highres mode

2007-03-04 Thread Andres Salomon
Ingo Molnar wrote: * Andres Salomon [EMAIL PROTECTED] wrote: Thomas Gleixner wrote: The question is, how the tick timer gets enqueued in the softirq queue. Can you isolate the codepath, where this happens ? The TIMER_SOFTIRQ runs the hrtimers during bootup until a usable clocksource and