RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-26 Thread Dexuan Cui
> From: David Hildenbrand > Sent: Thursday, September 26, 2019 12:20 AM > To: Dexuan Cui ; KY Srinivasan ; > Haiyang Zhang ; Stephen Hemminger > ; sas...@kernel.org; > linux-hyp...@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Kelley > > Subject: Re: [PATCH] hv_

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-26 Thread David Hildenbrand
On 25.09.19 22:03, Dexuan Cui wrote: >> From: linux-hyperv-ow...@vger.kernel.org >> [... snipped ...] >>> Anyhow, just some comments from my side :) I can see how Windows Server >>> worked around that issue right now by just XOR'ing both features. >>> >>> David / dhildenb >> >> Thanks for sharing

RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-25 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > [... snipped ...] > > Anyhow, just some comments from my side :) I can see how Windows Server > > worked around that issue right now by just XOR'ing both features. > > > > David / dhildenb > > Thanks for sharing your thoughts! > > -- Dexuan Hi

RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-13 Thread Dexuan Cui
> From: David Hildenbrand > Sent: Friday, September 13, 2019 2:44 PM > > > On recent Windows Server 2019+ hosts, the toolstacks on the hosts > > guarantees that Dynamic Memory and Memory Resizing can not be enabled > > if the virtual ACPI S4 state is enabled, and vice versa. Please refer to the >

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-13 Thread David Hildenbrand
On 13.09.19 22:54, Dexuan Cui wrote: >> From: David Hildenbrand >> Sent: Friday, September 13, 2019 12:46 AM >> >> On 12.09.19 21:18, Dexuan Cui wrote: >>> 3. Hibernation can be especially useful when we pass through a PCIe device, >>> e.g. a NIC, a NVMe controller or a GPU, to the VM, as usually

RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-13 Thread Dexuan Cui
> From: David Hildenbrand > Sent: Friday, September 13, 2019 12:46 AM > > On 12.09.19 21:18, Dexuan Cui wrote: > > 3. Hibernation can be especially useful when we pass through a PCIe device, > > e.g. a NIC, a NVMe controller or a GPU, to the VM, as usually save/restore > > and live migration can

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-13 Thread David Hildenbrand
On 12.09.19 21:18, Dexuan Cui wrote: >> From: David Hildenbrand >> Sent: Thursday, September 12, 2019 3:09 AM >> On 12.09.19 01:36, Dexuan Cui wrote: >>> When hibernation is enabled, we must ignore the balloon up/down and >>> hot-add requests from the host, if any. >> >> Why do you even care

RE: [PATCH] hv_balloon: Add the support of hibernation

2019-09-12 Thread Dexuan Cui
> From: David Hildenbrand > Sent: Thursday, September 12, 2019 3:09 AM > On 12.09.19 01:36, Dexuan Cui wrote: > > When hibernation is enabled, we must ignore the balloon up/down and > > hot-add requests from the host, if any. > > Why do you even care about supporting hibernation? Can't you just

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-12 Thread David Hildenbrand
On 12.09.19 12:08, David Hildenbrand wrote: > On 12.09.19 01:36, Dexuan Cui wrote: >> When hibernation is enabled, we must ignore the balloon up/down and >> hot-add requests from the host, if any. >> >> Fow now, if people want to test hibernation, please blacklist hv_balloon >> or do not enable

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-12 Thread David Hildenbrand
On 12.09.19 01:36, Dexuan Cui wrote: > When hibernation is enabled, we must ignore the balloon up/down and > hot-add requests from the host, if any. > > Fow now, if people want to test hibernation, please blacklist hv_balloon > or do not enable Dynamic Memory and Memory Resizing. See the comment

[PATCH] hv_balloon: Add the support of hibernation

2019-09-11 Thread Dexuan Cui
When hibernation is enabled, we must ignore the balloon up/down and hot-add requests from the host, if any. Fow now, if people want to test hibernation, please blacklist hv_balloon or do not enable Dynamic Memory and Memory Resizing. See the comment in balloon_probe() for more info.