Re: [PATCH] iomap: Switch to offset_in_page for clarity

2018-08-10 Thread Darrick J. Wong
[add linux-xfs to cc] On Fri, Aug 10, 2018 at 04:56:27PM +0200, Andreas Gruenbacher wrote: > Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use > the offset_in_page macro. > > Signed-off-by: Andreas Gruenbacher Looks ok, will test... Reviewed-by: Darrick J. Wong --D >

Re: [PATCH] iomap: Switch to offset_in_page for clarity

2018-08-10 Thread Darrick J. Wong
[add linux-xfs to cc] On Fri, Aug 10, 2018 at 04:56:27PM +0200, Andreas Gruenbacher wrote: > Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use > the offset_in_page macro. > > Signed-off-by: Andreas Gruenbacher Looks ok, will test... Reviewed-by: Darrick J. Wong --D >

[PATCH] iomap: Switch to offset_in_page for clarity

2018-08-10 Thread Andreas Gruenbacher
Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use the offset_in_page macro. Signed-off-by: Andreas Gruenbacher --- fs/iomap.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/iomap.c b/fs/iomap.c index 13cdcf33e6c0..ae317ac7e925

[PATCH] iomap: Switch to offset_in_page for clarity

2018-08-10 Thread Andreas Gruenbacher
Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use the offset_in_page macro. Signed-off-by: Andreas Gruenbacher --- fs/iomap.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/iomap.c b/fs/iomap.c index 13cdcf33e6c0..ae317ac7e925