Re: [PATCH] ixgbe: mark symbols static where possible
On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no > previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no > previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] > > In fact, these two functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This has been fixed and pushed upstream, why do you keep submitting this? signature.asc Description: This is a digitally signed message part
[PATCH] ixgbe: mark symbols static where possible
We get 2 warnings when building kernel with W=1: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] In fact, these two functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c index e092a89..dec8b11 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c @@ -2125,7 +2125,7 @@ static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw) * @hw: pointer to hardware structure * @led_idx: led number to turn on **/ -s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; @@ -2147,7 +2147,7 @@ s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) * @hw: pointer to hardware structure * @led_idx: led number to turn off **/ -s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; -- 2.7.4
RE: [PATCH] ixgbe: mark symbols static where possible
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Baoyou Xie >Sent: Sunday, September 18, 2016 1:48 AM >To: Kirsher, Jeffrey T ; intel-wired- >l...@lists.osuosl.org >Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; a...@arndb.de; >baoyou@linaro.org; xie.bao...@zte.com.cn >Subject: [PATCH] ixgbe: mark symbols static where possible > >We get 2 warnings when building kernel with W=1: >drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous >prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] >drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous >prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] Already taken care of: http://patchwork.ozlabs.org/patch/661647/ Thanks, Emil
[PATCH] ixgbe: mark symbols static where possible
We get 2 warnings when building kernel with W=1: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c index e092a89..dec8b11 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c @@ -2125,7 +2125,7 @@ static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw) * @hw: pointer to hardware structure * @led_idx: led number to turn on **/ -s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; @@ -2147,7 +2147,7 @@ s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx) * @hw: pointer to hardware structure * @led_idx: led number to turn off **/ -s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) +static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx) { u16 phy_data; -- 2.7.4