Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-12 Thread Randy Dunlap
On 03/11/2018 02:00 PM, Bjørn Forsman wrote: > On 11 March 2018 at 21:12, Randy Dunlap wrote: >> +pkgcfg=`which pkg-config >/dev/null 2>&1` > > Please use "command -v" instead of "which". command -v is in POSIX, so > the shell will have it for sure (builtin). which is not

Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-12 Thread Randy Dunlap
On 03/11/2018 02:00 PM, Bjørn Forsman wrote: > On 11 March 2018 at 21:12, Randy Dunlap wrote: >> +pkgcfg=`which pkg-config >/dev/null 2>&1` > > Please use "command -v" instead of "which". command -v is in POSIX, so > the shell will have it for sure (builtin). which is not a builtin, it > is an

Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-11 Thread Bjørn Forsman
On 11 March 2018 at 21:12, Randy Dunlap wrote: > +pkgcfg=`which pkg-config >/dev/null 2>&1` Please use "command -v" instead of "which". command -v is in POSIX, so the shell will have it for sure (builtin). which is not a builtin, it is an external command that may or may

Re: [PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-11 Thread Bjørn Forsman
On 11 March 2018 at 21:12, Randy Dunlap wrote: > +pkgcfg=`which pkg-config >/dev/null 2>&1` Please use "command -v" instead of "which". command -v is in POSIX, so the shell will have it for sure (builtin). which is not a builtin, it is an external command that may or may not be installed on the

[PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-11 Thread Randy Dunlap
From: Randy Dunlap Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure that other required files are present, but none of these check that pkg-config itself is present. Add a check for all 4 of these targets. Fixes kernel bugzilla #77511:

[PATCH] kbuild: check for pkg-config on make menu/n/g/xconfig

2018-03-11 Thread Randy Dunlap
From: Randy Dunlap Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure that other required files are present, but none of these check that pkg-config itself is present. Add a check for all 4 of these targets. Fixes kernel bugzilla #77511: