Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-21 Thread Miroslav Benes
On Thu, 20 Dec 2018, Joao Moreira wrote: > On 12/20/18 12:33 AM, Miroslav Benes wrote: > > On Wed, 19 Dec 2018, Jiri Kosina wrote: > > > >> On Wed, 19 Dec 2018, Josh Poimboeuf wrote: > >> > >>> Also the commit message needs an analysis of the performance impacts. > >> > >> Agreed. Especially as

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-21 Thread Miroslav Benes
On Thu, 20 Dec 2018, Josh Poimboeuf wrote: > On Thu, Dec 20, 2018 at 09:33:05AM +0100, Miroslav Benes wrote: > > > > Though, upstream, almost everybody seems to use kpatch-build, for which > > > > this patch doesn't help. And people will continue to do so until we > > > > have decent

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-20 Thread Joao Moreira
On 12/20/18 12:33 AM, Miroslav Benes wrote: On Wed, 19 Dec 2018, Jiri Kosina wrote: On Wed, 19 Dec 2018, Josh Poimboeuf wrote: Also the commit message needs an analysis of the performance impacts. Agreed. Especially as it's expected (*) to be completely in the noise particularly for the

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-20 Thread Josh Poimboeuf
On Thu, Dec 20, 2018 at 09:33:05AM +0100, Miroslav Benes wrote: > > > Though, upstream, almost everybody seems to use kpatch-build, for which > > > this patch doesn't help. And people will continue to do so until we > > > have decent source-based tooling. Will the klp-convert patches be > > >

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-20 Thread Miroslav Benes
On Wed, 19 Dec 2018, Jiri Kosina wrote: > On Wed, 19 Dec 2018, Josh Poimboeuf wrote: > > > Also the commit message needs an analysis of the performance impacts. > > Agreed. Especially as it's expected (*) to be completely in the noise > particularly for the kernel, it'd be good to have that

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-19 Thread Jiri Kosina
On Wed, 19 Dec 2018, Josh Poimboeuf wrote: > > > This option only makes sense for source-based patch generation, so isn't > > > it a bit premature to make this change without proper source-based patch > > > tooling? > > > > The reality is though that before the full-fledged patch tooling

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-19 Thread Josh Poimboeuf
On Wed, Dec 19, 2018 at 05:58:53PM +0100, Jiri Kosina wrote: > On Wed, 19 Dec 2018, Josh Poimboeuf wrote: > > > This option only makes sense for source-based patch generation, so isn't > > it a bit premature to make this change without proper source-based patch > > tooling? > > The reality is

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-19 Thread Jiri Kosina
On Wed, 19 Dec 2018, Josh Poimboeuf wrote: > This option only makes sense for source-based patch generation, so isn't > it a bit premature to make this change without proper source-based patch > tooling? The reality is though that before the full-fledged patch tooling exists, people are

Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-19 Thread Josh Poimboeuf
On Wed, Dec 19, 2018 at 03:17:44PM +0100, Miroslav Benes wrote: > GCC 9 introduces a new option, -flive-patching. It disables certain > optimizations which could make a compilation unsafe for later live > patching of the running kernel. > > The option is used only if CONFIG_LIVEPATCH is enabled

[PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled

2018-12-19 Thread Miroslav Benes
GCC 9 introduces a new option, -flive-patching. It disables certain optimizations which could make a compilation unsafe for later live patching of the running kernel. The option is used only if CONFIG_LIVEPATCH is enabled and $(CC) supports it. Signed-off-by: Miroslav Benes --- Makefile | 4