Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-10-13 Thread Rasmus Villemoes
On 10/07/2020 17.57, Matthew Wilcox wrote: > On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: >> The ability to check open file descriptions for equality (without >> resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be >> useful outside of the checkpoint/restore

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Matthew Wilcox
On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: > The ability to check open file descriptions for equality (without > resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be > useful outside of the checkpoint/restore use case - for example, > systemd uses kcmp() to

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Randy Dunlap
On 7/10/20 12:56 AM, Rasmus Villemoes wrote: > diff --git a/init/Kconfig b/init/Kconfig > index 0498af567f70..95e9486d4217 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1158,9 +1158,20 @@ config NET_NS > > endif # NAMESPACES > > +config KCMP_SYSCALL > + bool "kcmp system call" >

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Cyrill Gorcunov
On Fri, Jul 10, 2020 at 11:05:11AM +0200, Rasmus Villemoes wrote: > >> I deliberately drop the ifdef in the eventpoll.h header rather than > >> replace with KCMP_SYSCALL; it's harmless to declare a function that > >> isn't defined anywhere. > > > > Could you please point why setting #fidef

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Rasmus Villemoes
On 10/07/2020 10.30, Cyrill Gorcunov wrote: > On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: >> The ability to check open file descriptions for equality (without >> resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be >> useful outside of the checkpoint/restore

Re: [PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Cyrill Gorcunov
On Fri, Jul 10, 2020 at 09:56:31AM +0200, Rasmus Villemoes wrote: > The ability to check open file descriptions for equality (without > resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be > useful outside of the checkpoint/restore use case - for example, > systemd uses kcmp() to

[PATCH] kcmp: add separate Kconfig symbol for kcmp syscall

2020-07-10 Thread Rasmus Villemoes
The ability to check open file descriptions for equality (without resorting to unreliable fstat() and fcntl(F_GETFL) comparisons) can be useful outside of the checkpoint/restore use case - for example, systemd uses kcmp() to deduplicate the per-service file descriptor store. Make it possible to