Re: [PATCH] lib/raid6: align AVX512 constants to 512 bits, not bytes

2017-08-14 Thread Shaohua Li 
On Sat, Aug 12, 2017 at 07:43:46PM +0200, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko 
> Cc: H. Peter Anvin 
> Cc: mi...@redhat.com
> Cc: Jim Kukunas 
> Cc: Fenghua Yu 
> Cc: Megha Dey 
> Cc: Gayatri Kammela 
> Cc: Shaohua Li 
> Cc: x...@kernel.org
> Cc: linux-kernel@vger.kernel.org

applied, thanks!
> ---
>   avx512.o before:
> Sections:
> Idx Name  Size  VMA   LMA   File off  Algn
>   4 .rodata   0240      0c00  2**9
>   CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
> ...
> Contents of section .rodata:
>        
>  0010      
>  0020 0100     
>  0030      
>  0040      
>  0050      
>  0060 0100     
>  0070      
>  0080      
>  0090      
>  00a0 0100     
>  00b0      
>  00c0      
>  00d0      
>  00e0      
>  00f0      
>  0100      
>  0110      
>  0120      
>  0130      
>  0140      
>  0150      
>  0160      
>  0170      
>  0180      
>  0190      
>  01a0      
>  01b0      
>  01c0      
>  01d0      
>  01e0      
>  01f0      
>  0200 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  0210 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  0220 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  0230 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
> 
>   avx512.o after:
> Sections:
> Idx Name  Size  VMA   LMA   File off  Algn
>   4 .rodata   0100      0b40  2**6
>   CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
> ...
> Contents of section .rodata:
>        
>  0010      
>  0020 0100     
>  0030      
>  0040      
>  0050      
>  0060 0100     
>  0070      
>  0080      
>  0090      
>  00a0 0100     
>  00b0      
>  00c0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  00d0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  00e0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
>  00f0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
> 
> 
>  lib/raid6/avx512.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/raid6/avx512.c b/lib/raid6/avx512.c
> index f524a79..46df797 100644
> --- a/lib/raid6/avx512.c
> +++ b/lib/raid6/avx512.c
> @@ -29,7 +29,7 @@
>  
>  static const struct raid6_avx512_constants {
>   u64 x1d[8];
> -} raid6_avx512_constants __aligned(512) = {
> +} raid6_avx512_constants __aligned(512/8) = {
>   { 0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
> 0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
> 0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
> -- 
> 2.9.2
>

[PATCH] lib/raid6: align AVX512 constants to 512 bits, not bytes

2017-08-12 Thread Denys Vlasenko 
Signed-off-by: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: mi...@redhat.com
Cc: Jim Kukunas 
Cc: Fenghua Yu 
Cc: Megha Dey 
Cc: Gayatri Kammela 
Cc: Shaohua Li 
Cc: x...@kernel.org
Cc: linux-kernel@vger.kernel.org
---
avx512.o before:
Sections:
Idx Name  Size  VMA   LMA   File off  Algn
  4 .rodata   0240      0c00  2**9
  CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
...
Contents of section .rodata:
       
 0010      
 0020 0100     
 0030      
 0040      
 0050      
 0060 0100     
 0070      
 0080      
 0090      
 00a0 0100     
 00b0      
 00c0      
 00d0      
 00e0      
 00f0      
 0100      
 0110      
 0120      
 0130      
 0140      
 0150      
 0160      
 0170      
 0180      
 0190      
 01a0      
 01b0      
 01c0      
 01d0      
 01e0      
 01f0      
 0200 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 0210 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 0220 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 0230 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  

avx512.o after:
Sections:
Idx Name  Size  VMA   LMA   File off  Algn
  4 .rodata   0100      0b40  2**6
  CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
...
Contents of section .rodata:
       
 0010      
 0020 0100     
 0030      
 0040      
 0050      
 0060 0100     
 0070      
 0080      
 0090      
 00a0 0100     
 00b0      
 00c0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 00d0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 00e0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  
 00f0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d  


 lib/raid6/avx512.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/raid6/avx512.c b/lib/raid6/avx512.c
index f524a79..46df797 100644
--- a/lib/raid6/avx512.c
+++ b/lib/raid6/avx512.c
@@ -29,7 +29,7 @@
 
 static const struct raid6_avx512_constants {
u64 x1d[8];
-} raid6_avx512_constants __aligned(512) = {
+} raid6_avx512_constants __aligned(512/8) = {
{ 0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
  0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
  0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
-- 
2.9.2