Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
On Tue, 28 Aug 2018 at 03:54, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-o...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/memory/omap-gpmc.c | 18 +++--- > drivers/memory/samsung/exynos-srom.c | 4 ++-- For Samsung: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof
Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
On Tue, 28 Aug 2018 at 03:54, Rob Herring wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-o...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/memory/omap-gpmc.c | 18 +++--- > drivers/memory/samsung/exynos-srom.c | 4 ++-- For Samsung: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof
Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
* Rob Herring [180828 01:58]: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. ... > drivers/memory/omap-gpmc.c | 18 +++--- Looks good to me: Acked-by: Tony Lindgren
Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
* Rob Herring [180828 01:58]: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. ... > drivers/memory/omap-gpmc.c | 18 +++--- Looks good to me: Acked-by: Tony Lindgren
Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
On Mon, Aug 27, 2018 at 08:52:30PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-o...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/memory/omap-gpmc.c | 18 +++--- > drivers/memory/samsung/exynos-srom.c | 4 ++-- > drivers/memory/tegra/mc.c| 6 +++--- > drivers/memory/tegra/tegra124-emc.c | 12 ++-- > 4 files changed, 18 insertions(+), 22 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature
Re: [PATCH] memory: Convert to using %pOFn instead of device_node.name
On Mon, Aug 27, 2018 at 08:52:30PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Roger Quadros > Cc: Tony Lindgren > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-o...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/memory/omap-gpmc.c | 18 +++--- > drivers/memory/samsung/exynos-srom.c | 4 ++-- > drivers/memory/tegra/mc.c| 6 +++--- > drivers/memory/tegra/tegra124-emc.c | 12 ++-- > 4 files changed, 18 insertions(+), 22 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature
[PATCH] memory: Convert to using %pOFn instead of device_node.name
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.
Cc: Roger Quadros
Cc: Tony Lindgren
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: Thierry Reding
Cc: Jonathan Hunter
Cc: linux-o...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Rob Herring
---
drivers/memory/omap-gpmc.c | 18 +++---
drivers/memory/samsung/exynos-srom.c | 4 ++--
drivers/memory/tegra/mc.c| 6 +++---
drivers/memory/tegra/tegra124-emc.c | 12 ++--
4 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index c215287e80cf..8abb9e94916a 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2145,8 +2145,8 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
gpmc_s.device_width = GPMC_DEVWIDTH_16BIT;
break;
default:
- dev_err(>dev, "%s: invalid 'nand-bus-width'\n",
- child->name);
+ dev_err(>dev, "%pOFn: invalid 'nand-bus-width'\n",
+ child);
ret = -EINVAL;
goto err;
}
@@ -2186,8 +2186,8 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
ret = gpmc_cs_set_timings(cs, _t, _s);
if (ret) {
- dev_err(>dev, "failed to set gpmc timings for: %s\n",
- child->name);
+ dev_err(>dev, "failed to set gpmc timings for: %pOFn\n",
+ child);
goto err_cs;
}
@@ -2215,7 +2215,7 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
err_child_fail:
- dev_err(>dev, "failed to create gpmc child %s\n", child->name);
+ dev_err(>dev, "failed to create gpmc child %pOFn\n", child);
ret = -ENODEV;
err_cs:
@@ -2265,14 +2265,10 @@ static void gpmc_probe_dt_children(struct
platform_device *pdev)
struct device_node *child;
for_each_available_child_of_node(pdev->dev.of_node, child) {
-
- if (!child->name)
- continue;
-
ret = gpmc_probe_generic_child(pdev, child);
if (ret) {
- dev_err(>dev, "failed to probe DT child '%s':
%d\n",
- child->name, ret);
+ dev_err(>dev, "failed to probe DT child '%pOFn':
%d\n",
+ child, ret);
}
}
}
diff --git a/drivers/memory/samsung/exynos-srom.c
b/drivers/memory/samsung/exynos-srom.c
index 7edd7fb540f2..c27c6105c66d 100644
--- a/drivers/memory/samsung/exynos-srom.c
+++ b/drivers/memory/samsung/exynos-srom.c
@@ -139,8 +139,8 @@ static int exynos_srom_probe(struct platform_device *pdev)
for_each_child_of_node(np, child) {
if (exynos_srom_configure_bank(srom, child)) {
dev_err(dev,
- "Could not decode bank configuration for %s\n",
- child->name);
+ "Could not decode bank configuration for
%pOFn\n",
+ child);
bad_bank_config = true;
}
}
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index bd25faf6d13d..24afc36833bf 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -345,7 +345,7 @@ static int load_one_timing(struct tegra_mc *mc,
err = of_property_read_u32(node, "clock-frequency", );
if (err) {
dev_err(mc->dev,
- "timing %s: failed to read rate\n", node->name);
+ "timing %pOFn: failed to read rate\n", node);
return err;
}
@@ -360,8 +360,8 @@ static int load_one_timing(struct tegra_mc *mc,
mc->soc->num_emem_regs);
if (err) {
dev_err(mc->dev,
- "timing %s: failed to read EMEM configuration\n",
- node->name);
+ "timing %pOFn: failed to read EMEM configuration\n",
+ node);
return err;
}
diff --git a/drivers/memory/tegra/tegra124-emc.c
b/drivers/memory/tegra/tegra124-emc.c
index 392dc8dd481f..eedb7d48e2ea 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -888,8 +888,8 @@ static int load_one_timing_from_dt(struct tegra_emc *emc,
err = of_property_read_u32(node, "clock-frequency", );
if (err) {
- dev_err(emc->dev, "timing %s: failed to read rate: %d\n",
- node->name, err);
+
[PATCH] memory: Convert to using %pOFn instead of device_node.name
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.
Cc: Roger Quadros
Cc: Tony Lindgren
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: Thierry Reding
Cc: Jonathan Hunter
Cc: linux-o...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Rob Herring
---
drivers/memory/omap-gpmc.c | 18 +++---
drivers/memory/samsung/exynos-srom.c | 4 ++--
drivers/memory/tegra/mc.c| 6 +++---
drivers/memory/tegra/tegra124-emc.c | 12 ++--
4 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index c215287e80cf..8abb9e94916a 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2145,8 +2145,8 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
gpmc_s.device_width = GPMC_DEVWIDTH_16BIT;
break;
default:
- dev_err(>dev, "%s: invalid 'nand-bus-width'\n",
- child->name);
+ dev_err(>dev, "%pOFn: invalid 'nand-bus-width'\n",
+ child);
ret = -EINVAL;
goto err;
}
@@ -2186,8 +2186,8 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
ret = gpmc_cs_set_timings(cs, _t, _s);
if (ret) {
- dev_err(>dev, "failed to set gpmc timings for: %s\n",
- child->name);
+ dev_err(>dev, "failed to set gpmc timings for: %pOFn\n",
+ child);
goto err_cs;
}
@@ -2215,7 +2215,7 @@ static int gpmc_probe_generic_child(struct
platform_device *pdev,
err_child_fail:
- dev_err(>dev, "failed to create gpmc child %s\n", child->name);
+ dev_err(>dev, "failed to create gpmc child %pOFn\n", child);
ret = -ENODEV;
err_cs:
@@ -2265,14 +2265,10 @@ static void gpmc_probe_dt_children(struct
platform_device *pdev)
struct device_node *child;
for_each_available_child_of_node(pdev->dev.of_node, child) {
-
- if (!child->name)
- continue;
-
ret = gpmc_probe_generic_child(pdev, child);
if (ret) {
- dev_err(>dev, "failed to probe DT child '%s':
%d\n",
- child->name, ret);
+ dev_err(>dev, "failed to probe DT child '%pOFn':
%d\n",
+ child, ret);
}
}
}
diff --git a/drivers/memory/samsung/exynos-srom.c
b/drivers/memory/samsung/exynos-srom.c
index 7edd7fb540f2..c27c6105c66d 100644
--- a/drivers/memory/samsung/exynos-srom.c
+++ b/drivers/memory/samsung/exynos-srom.c
@@ -139,8 +139,8 @@ static int exynos_srom_probe(struct platform_device *pdev)
for_each_child_of_node(np, child) {
if (exynos_srom_configure_bank(srom, child)) {
dev_err(dev,
- "Could not decode bank configuration for %s\n",
- child->name);
+ "Could not decode bank configuration for
%pOFn\n",
+ child);
bad_bank_config = true;
}
}
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index bd25faf6d13d..24afc36833bf 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -345,7 +345,7 @@ static int load_one_timing(struct tegra_mc *mc,
err = of_property_read_u32(node, "clock-frequency", );
if (err) {
dev_err(mc->dev,
- "timing %s: failed to read rate\n", node->name);
+ "timing %pOFn: failed to read rate\n", node);
return err;
}
@@ -360,8 +360,8 @@ static int load_one_timing(struct tegra_mc *mc,
mc->soc->num_emem_regs);
if (err) {
dev_err(mc->dev,
- "timing %s: failed to read EMEM configuration\n",
- node->name);
+ "timing %pOFn: failed to read EMEM configuration\n",
+ node);
return err;
}
diff --git a/drivers/memory/tegra/tegra124-emc.c
b/drivers/memory/tegra/tegra124-emc.c
index 392dc8dd481f..eedb7d48e2ea 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -888,8 +888,8 @@ static int load_one_timing_from_dt(struct tegra_emc *emc,
err = of_property_read_u32(node, "clock-frequency", );
if (err) {
- dev_err(emc->dev, "timing %s: failed to read rate: %d\n",
- node->name, err);
+
