Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 02:18:36PM -0700, Paul E. McKenney wrote: > On Thu, Apr 12, 2018 at 01:21:55PM +0200, Andrea Parri wrote: > > > > The litmus test that first comes to my mind when I think of cumulativity > > (at least, 'cumulativity' as intended in LKMM) is: > > > >

Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 02:18:36PM -0700, Paul E. McKenney wrote: > On Thu, Apr 12, 2018 at 01:21:55PM +0200, Andrea Parri wrote: > > > > The litmus test that first comes to my mind when I think of cumulativity > > (at least, 'cumulativity' as intended in LKMM) is: > > > >

Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 01:21:55PM +0200, Andrea Parri wrote: > On Thu, Apr 12, 2018 at 12:18:13PM +0200, Paolo Bonzini wrote: > > On 12/04/2018 11:23, Andrea Parri wrote: > > >> > > >> - smp_store_mb() is missing > > > > > > Good point. In fact, we could add this to the model as well: > > >

Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 01:21:55PM +0200, Andrea Parri wrote: > On Thu, Apr 12, 2018 at 12:18:13PM +0200, Paolo Bonzini wrote: > > On 12/04/2018 11:23, Andrea Parri wrote: > > >> > > >> - smp_store_mb() is missing > > > > > > Good point. In fact, we could add this to the model as well: > > >

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 07:06:36PM +0200, Paolo Bonzini wrote: > On 11/04/2018 18:31, Peter Zijlstra wrote: > >>>Prior Operation Subsequent Operation > >>>--- - > >>>

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 07:06:36PM +0200, Paolo Bonzini wrote: > On 11/04/2018 18:31, Peter Zijlstra wrote: > >>>Prior Operation Subsequent Operation > >>>--- - > >>>

Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 12:18:13PM +0200, Paolo Bonzini wrote: > On 12/04/2018 11:23, Andrea Parri wrote: > >> > >> - smp_store_mb() is missing > > > > Good point. In fact, we could add this to the model as well: > > following Peter's remark/the generic implementation, > > Good idea.

Re: [PATCH] memory-model: fix cheat sheet typo

On Thu, Apr 12, 2018 at 12:18:13PM +0200, Paolo Bonzini wrote: > On 12/04/2018 11:23, Andrea Parri wrote: > >> > >> - smp_store_mb() is missing > > > > Good point. In fact, we could add this to the model as well: > > following Peter's remark/the generic implementation, > > Good idea.

Re: [PATCH] memory-model: fix cheat sheet typo

On 12/04/2018 11:23, Andrea Parri wrote: >> >> - smp_store_mb() is missing > > Good point. In fact, we could add this to the model as well: > following Peter's remark/the generic implementation, Good idea. smp_store_mb() can save some clock cycles in the relatively common idiom write a

Re: [PATCH] memory-model: fix cheat sheet typo

On 12/04/2018 11:23, Andrea Parri wrote: >> >> - smp_store_mb() is missing > > Good point. In fact, we could add this to the model as well: > following Peter's remark/the generic implementation, Good idea. smp_store_mb() can save some clock cycles in the relatively common idiom write a

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 01:15:58PM +0200, Paolo Bonzini wrote: > On 10/04/2018 23:34, Paul E. McKenney wrote: > > Glad it helps, and I have queued it for the next merge window. Of course, > > if a further improvement comes to mind, please do not keep it a secret. ;-) > > Yes, there are several

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 01:15:58PM +0200, Paolo Bonzini wrote: > On 10/04/2018 23:34, Paul E. McKenney wrote: > > Glad it helps, and I have queued it for the next merge window. Of course, > > if a further improvement comes to mind, please do not keep it a secret. ;-) > > Yes, there are several

Re: [PATCH] memory-model: fix cheat sheet typo

On 11/04/2018 18:31, Peter Zijlstra wrote: >>>Prior Operation Subsequent Operation >>>--- - >>>R W RMW SV R W DR DW RMW SV >>>

Re: [PATCH] memory-model: fix cheat sheet typo

On 11/04/2018 18:31, Peter Zijlstra wrote: >>>Prior Operation Subsequent Operation >>>--- - >>>R W RMW SV R W DR DW RMW SV >>>

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 09:19:56AM -0700, Paul E. McKenney wrote: > > > >Prior Operation Subsequent Operation > >--- - > >R W RMW SV R W DR DW

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 09:19:56AM -0700, Paul E. McKenney wrote: > > > >Prior Operation Subsequent Operation > >--- - > >R W RMW SV R W DR DW

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 01:15:58PM +0200, Paolo Bonzini wrote: > On 10/04/2018 23:34, Paul E. McKenney wrote: > > Glad it helps, and I have queued it for the next merge window. Of course, > > if a further improvement comes to mind, please do not keep it a secret. ;-) > > Yes, there are several

Re: [PATCH] memory-model: fix cheat sheet typo

On Wed, Apr 11, 2018 at 01:15:58PM +0200, Paolo Bonzini wrote: > On 10/04/2018 23:34, Paul E. McKenney wrote: > > Glad it helps, and I have queued it for the next merge window. Of course, > > if a further improvement comes to mind, please do not keep it a secret. ;-) > > Yes, there are several

Re: [PATCH] memory-model: fix cheat sheet typo

On 10/04/2018 23:34, Paul E. McKenney wrote: > Glad it helps, and I have queued it for the next merge window. Of course, > if a further improvement comes to mind, please do not keep it a secret. ;-) Yes, there are several changes that could be included: - SV could be added to the prior

Re: [PATCH] memory-model: fix cheat sheet typo

On 10/04/2018 23:34, Paul E. McKenney wrote: > Glad it helps, and I have queued it for the next merge window. Of course, > if a further improvement comes to mind, please do not keep it a secret. ;-) Yes, there are several changes that could be included: - SV could be added to the prior

Re: [PATCH] memory-model: fix cheat sheet typo

On Tue, Apr 10, 2018 at 11:10:06PM +0200, Paolo Bonzini wrote: > On 10/04/2018 22:32, Paul E. McKenney wrote: > > On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: > >> On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > >>> "RWM" should be "RMW", and that's more or

Re: [PATCH] memory-model: fix cheat sheet typo

On Tue, Apr 10, 2018 at 11:10:06PM +0200, Paolo Bonzini wrote: > On 10/04/2018 22:32, Paul E. McKenney wrote: > > On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: > >> On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > >>> "RWM" should be "RMW", and that's more or

Re: [PATCH] memory-model: fix cheat sheet typo

On 10/04/2018 22:32, Paul E. McKenney wrote: > On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: >> On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: >>> "RWM" should be "RMW", and that's more or less the extent to which I >>> can claim to change the document. :) In

Re: [PATCH] memory-model: fix cheat sheet typo

On 10/04/2018 22:32, Paul E. McKenney wrote: > On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: >> On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: >>> "RWM" should be "RMW", and that's more or less the extent to which I >>> can claim to change the document. :) In

Re: [PATCH] memory-model: fix cheat sheet typo

On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: > On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > > "RWM" should be "RMW", and that's more or less the extent to which I > > can claim to change the document. :) In particular, "Self" is not > > documented and the

Re: [PATCH] memory-model: fix cheat sheet typo

On Mon, Apr 09, 2018 at 11:42:58AM -0700, Paul E. McKenney wrote: > On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > > "RWM" should be "RMW", and that's more or less the extent to which I > > can claim to change the document. :) In particular, "Self" is not > > documented and the

Re: [PATCH] memory-model: fix cheat sheet typo

On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > "RWM" should be "RMW", and that's more or less the extent to which I > can claim to change the document. :) In particular, "Self" is not > documented and the difference between "Self" and "SV" is not clear > to me. > >

Re: [PATCH] memory-model: fix cheat sheet typo

On Mon, Apr 09, 2018 at 06:50:15PM +0200, Paolo Bonzini wrote: > "RWM" should be "RMW", and that's more or less the extent to which I > can claim to change the document. :) In particular, "Self" is not > documented and the difference between "Self" and "SV" is not clear > to me. > >

[PATCH] memory-model: fix cheat sheet typo

"RWM" should be "RMW", and that's more or less the extent to which I can claim to change the document. :) In particular, "Self" is not documented and the difference between "Self" and "SV" is not clear to me. Signed-off-by: Paolo Bonzini ---

[PATCH] memory-model: fix cheat sheet typo

"RWM" should be "RMW", and that's more or less the extent to which I can claim to change the document. :) In particular, "Self" is not documented and the difference between "Self" and "SV" is not clear to me. Signed-off-by: Paolo Bonzini --- tools/memory-model/Documentation/cheatsheet.txt | 2