Re: [PATCH] mm/gup: Fixed coding style error and warnings.

2018-02-13 Thread Matthew Wilcox
On Tue, Feb 13, 2018 at 02:17:22PM -0500, Mario Leinweber wrote: > if (flags & FOLL_SPLIT && PageTransCompound(page)) { > int ret; > + > get_page(page); Hi Mario, Thanks for your patch, but this kind of change to the Linux core is not generally welcomed. There a

Re: [PATCH] mm/gup: Fixed coding style error and warnings.

2018-02-13 Thread Joe Perches
You should have a changelog. On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote: [] > diff --git a/mm/gup.c b/mm/gup.c [] > @@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, > unsigned long end, >PMD_SHIFT, next, write, pag

[PATCH] mm/gup: Fixed coding style error and warnings.

2018-02-13 Thread Mario Leinweber
Signed-off-by: Mario Leinweber --- mm/gup.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 1b46e6e74881..7e463042df4a 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -141,6 +141,7 @@ static struct page *follow_page_pte(struct vm_area_struct *vma,