Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Ping? On Wed, Sep 21, 2016 at 10:26 AM, Ricardo Ribalda Delgado wrote: > Hi > >>> >>> Unsinged long is more than enough for s3an. I think v7 is ok. >> >> Then, why did you change the spi_nor_s3an_addr_convert() prototype? >> > > Because it is used in spi_nor_read and

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Ping? On Wed, Sep 21, 2016 at 10:26 AM, Ricardo Ribalda Delgado wrote: > Hi > >>> >>> Unsinged long is more than enough for s3an. I think v7 is ok. >> >> Then, why did you change the spi_nor_s3an_addr_convert() prototype? >> > > Because it is used in spi_nor_read and spi_nor_write, which use

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi >> >> Unsinged long is more than enough for s3an. I think v7 is ok. > > Then, why did you change the spi_nor_s3an_addr_convert() prototype? > Because it is used in spi_nor_read and spi_nor_write, which use loff_t. I think it is more clean to have only one comment explaining the max size of

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi >> >> Unsinged long is more than enough for s3an. I think v7 is ok. > > Then, why did you change the spi_nor_s3an_addr_convert() prototype? > Because it is used in spi_nor_read and spi_nor_write, which use loff_t. I think it is more clean to have only one comment explaining the max size of

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 10:19:10 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 10:14 AM, Boris Brezillon > wrote: > > Wait. If you really want to manipulate an loff_t variable, you can do > > > >

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 10:19:10 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 10:14 AM, Boris Brezillon > wrote: > > Wait. If you really want to manipulate an loff_t variable, you can do > > > > offset = do_div(addr, nor->page_size); > > > > > > > that

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 10:14:20 +0200 Boris Brezillon wrote: > On Wed, 21 Sep 2016 09:57:23 +0200 > Ricardo Ribalda Delgado wrote: > > > Hi Boris > > > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > >

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 10:14:20 +0200 Boris Brezillon wrote: > On Wed, 21 Sep 2016 09:57:23 +0200 > Ricardo Ribalda Delgado wrote: > > > Hi Boris > > > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > > wrote: > > > Hi Ricardo, > > > > > > Please try to pass the version in your subject

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Boris On Wed, Sep 21, 2016 at 10:14 AM, Boris Brezillon wrote: > Wait. If you really want to manipulate an loff_t variable, you can do > > offset = do_div(addr, nor->page_size); > > > that leads to: CC drivers/mtd/spi-nor/spi-nor.o

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Boris On Wed, Sep 21, 2016 at 10:14 AM, Boris Brezillon wrote: > Wait. If you really want to manipulate an loff_t variable, you can do > > offset = do_div(addr, nor->page_size); > > > that leads to: CC drivers/mtd/spi-nor/spi-nor.o drivers/mtd/spi-nor/spi-nor.c: In function

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 09:57:23 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > wrote: > > Hi Ricardo, > > > > Please try to pass the version in your subject prefix (pass > >

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

On Wed, 21 Sep 2016 09:57:23 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > > On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon > wrote: > > Hi Ricardo, > > > > Please try to pass the version in your subject prefix (pass > > --subject-prefix="PATCH vX" to git format-patch). > > > > Sorry

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Boris On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon wrote: > Hi Ricardo, > > Please try to pass the version in your subject prefix (pass > --subject-prefix="PATCH vX" to git format-patch). > Sorry about that. > On Tue, 20 Sep 2016 17:45:51 +0200 >

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Boris On Wed, Sep 21, 2016 at 9:07 AM, Boris Brezillon wrote: > Hi Ricardo, > > Please try to pass the version in your subject prefix (pass > --subject-prefix="PATCH vX" to git format-patch). > Sorry about that. > On Tue, 20 Sep 2016 17:45:51 +0200 > Ricardo Ribalda Delgado wrote: >> /*

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Ricardo, Please try to pass the version in your subject prefix (pass --subject-prefix="PATCH vX" to git format-patch). On Tue, 20 Sep 2016 17:45:51 +0200 Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep > their

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Ricardo, Please try to pass the version in your subject prefix (pass --subject-prefix="PATCH vX" to git format-patch). On Tue, 20 Sep 2016 17:45:51 +0200 Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep > their configuration data and

[PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep their configuration data and (optionally) some user data. The protocol of this flash follows most of the spi-nor standard. With the following differences: - Page size might not be a power of two. - The address calculation

[PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep their configuration data and (optionally) some user data. The protocol of this flash follows most of the spi-nor standard. With the following differences: - Page size might not be a power of two. - The address calculation

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hello It has been almost two months :)... Any feedback about the patch before I port it to the next version and resend? Regards! On Fri, Jan 22, 2016 at 3:52 PM, Ricardo Ribalda Delgado wrote: > ping? > > > On Fri, Jan 15, 2016 at 5:25 PM, Ricardo Ribalda Delgado >

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

Hello It has been almost two months :)... Any feedback about the patch before I port it to the next version and resend? Regards! On Fri, Jan 22, 2016 at 3:52 PM, Ricardo Ribalda Delgado wrote: > ping? > > > On Fri, Jan 15, 2016 at 5:25 PM, Ricardo Ribalda Delgado > wrote: >> Xilinx

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

ping? On Fri, Jan 15, 2016 at 5:25 PM, Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN contain an embedded spi device where they keep their > configuration data and optionally some user data. > > The protocol of this flash follows most of the spi-nor standard. With > the following

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

ping? On Fri, Jan 15, 2016 at 5:25 PM, Ricardo Ribalda Delgado wrote: > Xilinx Spartan-3AN contain an embedded spi device where they keep their > configuration data and optionally some user data. > > The protocol of this flash follows most of the spi-nor standard.