RE: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Remanan Pillai, Vineeth
Hellwig; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Kamata, Munehisa; Liguori, Anthony Subject: Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag On Thu, Oct 13, 2016 at 03:14:23PM -0700, Vineeth Remanan Pillai wrote: > Unfortunately, I also

RE: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Remanan Pillai, Vineeth
Hellwig; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; Kamata, Munehisa; Liguori, Anthony Subject: Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag On Thu, Oct 13, 2016 at 03:14:23PM -0700, Vineeth Remanan Pillai wrote: > Unfortunately, I also

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 03:14:23PM -0700, Vineeth Remanan Pillai wrote: > Unfortunately, I also do not have enough context about the customer > code that uses it. Since kern_path was exported function and the > behavior changed across releases, this patch is just trying to revert > to the old

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 03:14:23PM -0700, Vineeth Remanan Pillai wrote: > Unfortunately, I also do not have enough context about the customer > code that uses it. Since kern_path was exported function and the > behavior changed across releases, this patch is just trying to revert > to the old

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
On 10/13/2016 02:24 PM, Al Viro wrote: On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: Yes, the use case is out-of-tree and the code snippet above depicts the use . Since kern_path_locked is also not exported, out-of-tree code used kern_path for the existence check for

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
On 10/13/2016 02:24 PM, Al Viro wrote: On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: Yes, the use case is out-of-tree and the code snippet above depicts the use . Since kern_path_locked is also not exported, out-of-tree code used kern_path for the existence check for

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: > Yes, the use case is out-of-tree and the code snippet above depicts the use > . > Since kern_path_locked is also not exported, out-of-tree code used kern_path > for the existence check for directories. > > One reference

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: > Yes, the use case is out-of-tree and the code snippet above depicts the use > . > Since kern_path_locked is also not exported, out-of-tree code used kern_path > for the existence check for directories. > > One reference

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 01:09:04PM -0700, Christoph Hellwig wrote: > On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > > filename_lookup used to return success for non-existing file when called > > with LOOKUP_PARENT flag. This behaviour was changed with > > commit

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 01:09:04PM -0700, Christoph Hellwig wrote: > On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > > filename_lookup used to return success for non-existing file when called > > with LOOKUP_PARENT flag. This behaviour was changed with > > commit

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Christoph Hellwig
On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: > Yes, the use case is out-of-tree and the code snippet above depicts the use Case closed then. If it doesn't affect any in-tree code please don't bother spamming linux lists with your self-inflicted wounds.

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Christoph Hellwig
On Thu, Oct 13, 2016 at 01:41:11PM -0700, Vineeth Remanan Pillai wrote: > Yes, the use case is out-of-tree and the code snippet above depicts the use Case closed then. If it doesn't affect any in-tree code please don't bother spamming linux lists with your self-inflicted wounds.

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
On 10/13/2016 01:26 PM, Al Viro wrote: On Thu, Oct 13, 2016 at 01:09:04PM -0700, Christoph Hellwig wrote: On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: filename_lookup used to return success for non-existing file when called with LOOKUP_PARENT flag. This behaviour was

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
On 10/13/2016 01:26 PM, Al Viro wrote: On Thu, Oct 13, 2016 at 01:09:04PM -0700, Christoph Hellwig wrote: On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: filename_lookup used to return success for non-existing file when called with LOOKUP_PARENT flag. This behaviour was

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Christoph Hellwig
On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > filename_lookup used to return success for non-existing file when called > with LOOKUP_PARENT flag. This behaviour was changed with > commit 8bcb77fabd7c ("namei: split off filename_lookupat() > with LOOKUP_PARENT") > > The

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Christoph Hellwig
On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > filename_lookup used to return success for non-existing file when called > with LOOKUP_PARENT flag. This behaviour was changed with > commit 8bcb77fabd7c ("namei: split off filename_lookupat() > with LOOKUP_PARENT") > > The

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > filename_lookup used to return success for non-existing file when called > with LOOKUP_PARENT flag. This behaviour was changed with > commit 8bcb77fabd7c ("namei: split off filename_lookupat() > with LOOKUP_PARENT") > > The

Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Al Viro
On Thu, Oct 13, 2016 at 07:58:51PM +, Vineeth Remanan Pillai wrote: > filename_lookup used to return success for non-existing file when called > with LOOKUP_PARENT flag. This behaviour was changed with > commit 8bcb77fabd7c ("namei: split off filename_lookupat() > with LOOKUP_PARENT") > > The

[PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
filename_lookup used to return success for non-existing file when called with LOOKUP_PARENT flag. This behaviour was changed with commit 8bcb77fabd7c ("namei: split off filename_lookupat() with LOOKUP_PARENT") The above patch split parent lookup functionality to a different function

[PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag

2016-10-13 Thread Vineeth Remanan Pillai
filename_lookup used to return success for non-existing file when called with LOOKUP_PARENT flag. This behaviour was changed with commit 8bcb77fabd7c ("namei: split off filename_lookupat() with LOOKUP_PARENT") The above patch split parent lookup functionality to a different function