Re: [PATCH] nds32: To use the generic dump_stack()

[Sergey Senozhatsky]

On (03/07/18 18:10), Greentime Hu wrote:
> 
> Use the generic dump_stack() instead of nds32 one because they are doing
> the same thing.
> 
> Signed-off-by: Greentime Hu 
> Acked-by: Arnd Bergmann 

Thanks!

FWIW,
Reviewed-by: Sergey Senozhatsky 

-ss

Re: [PATCH] nds32: To use the generic dump_stack()

[Sergey Senozhatsky]

On (03/07/18 18:10), Greentime Hu wrote:
> 
> Use the generic dump_stack() instead of nds32 one because they are doing
> the same thing.
> 
> Signed-off-by: Greentime Hu 
> Acked-by: Arnd Bergmann 

Thanks!

FWIW,
Reviewed-by: Sergey Senozhatsky 

-ss

[PATCH] nds32: To use the generic dump_stack()

[Greentime Hu]

Use the generic dump_stack() instead of nds32 one because they are doing
the same thing.

Signed-off-by: Greentime Hu 
Acked-by: Arnd Bergmann 
---
 arch/nds32/kernel/traps.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/arch/nds32/kernel/traps.c b/arch/nds32/kernel/traps.c
index 8828b4aeb72b..6e34eb9824a4 100644
--- a/arch/nds32/kernel/traps.c
+++ b/arch/nds32/kernel/traps.c
@@ -156,18 +156,6 @@ static void __dump(struct task_struct *tsk, unsigned long 
*base_reg)
pr_emerg("\n");
 }
 
-void dump_stack(void)
-{
-   unsigned long *base_reg;
-   if (!IS_ENABLED(CONFIG_FRAME_POINTER))
-   __asm__ __volatile__("\tori\t%0, $sp, #0\n":"=r"(base_reg));
-   else
-   __asm__ __volatile__("\tori\t%0, $fp, #0\n":"=r"(base_reg));
-   __dump(NULL, base_reg);
-}
-
-EXPORT_SYMBOL(dump_stack);
-
 void show_stack(struct task_struct *tsk, unsigned long *sp)
 {
unsigned long *base_reg;
-- 
2.16.1

[PATCH] nds32: To use the generic dump_stack()

[Greentime Hu]

Use the generic dump_stack() instead of nds32 one because they are doing
the same thing.

Signed-off-by: Greentime Hu 
Acked-by: Arnd Bergmann 
---
 arch/nds32/kernel/traps.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/arch/nds32/kernel/traps.c b/arch/nds32/kernel/traps.c
index 8828b4aeb72b..6e34eb9824a4 100644
--- a/arch/nds32/kernel/traps.c
+++ b/arch/nds32/kernel/traps.c
@@ -156,18 +156,6 @@ static void __dump(struct task_struct *tsk, unsigned long 
*base_reg)
pr_emerg("\n");
 }
 
-void dump_stack(void)
-{
-   unsigned long *base_reg;
-   if (!IS_ENABLED(CONFIG_FRAME_POINTER))
-   __asm__ __volatile__("\tori\t%0, $sp, #0\n":"=r"(base_reg));
-   else
-   __asm__ __volatile__("\tori\t%0, $fp, #0\n":"=r"(base_reg));
-   __dump(NULL, base_reg);
-}
-
-EXPORT_SYMBOL(dump_stack);
-
 void show_stack(struct task_struct *tsk, unsigned long *sp)
 {
unsigned long *base_reg;
-- 
2.16.1