Re: [PATCH] ovl: avoid setting uninitialized creds

2016-09-19 Thread Miklos Szeredi
On Mon, Sep 19, 2016 at 2:38 PM, Arnd Bergmann wrote: > If the call to ovl_copy_up() fails, we now call revert_creds on > an uninitialized structure after a recent patch, as found > by "gcc -Wmayby-uninitialized": > > fs/overlayfs/inode.c: In function 'ovl_open_maybe_copy_up': > fs/overlayfs/inode

[PATCH] ovl: avoid setting uninitialized creds

2016-09-19 Thread Arnd Bergmann
If the call to ovl_copy_up() fails, we now call revert_creds on an uninitialized structure after a recent patch, as found by "gcc -Wmayby-uninitialized": fs/overlayfs/inode.c: In function 'ovl_open_maybe_copy_up': fs/overlayfs/inode.c:39:2: error: 'old_cred' may be used uninitialized in this func