Re: [PATCH] parisc: fix compilation errrors
On Thu, 22 Aug 2019 16:04:38 -0700 Guenter Roeck wrote:
> >>> Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable
> >>> 'p4d' set but not used")
> >>> Reported-by: Guenter Roeck
> >>> Signed-off-by: Qian Cai
> >>
> >> Tested-by: Guenter Roeck
> >
> > Acked-by: Helge Deller
> >
> > Helge
> >
>
> Any chance to push this patch into mainline anytime soon ? It has been applied
> to -next, but all parisc builds in mainline are still broken.
I'll be including it in tomorrow's patchpile->Linus.
Re: [PATCH] parisc: fix compilation errrors
On 8/22/19 1:53 PM, Helge Deller wrote:
On 15.08.19 23:02, Guenter Roeck wrote:
On Thu, Aug 15, 2019 at 04:53:05PM -0400, Qian Cai wrote:
The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
variable 'p4d' set but not used") converted a few functions from macros
to static inline, which causes parisc to complain,
In file included from ./include/asm-generic/4level-fixup.h:38:0,
from ./arch/parisc/include/asm/pgtable.h:5,
from ./arch/parisc/include/asm/io.h:6,
from ./include/linux/io.h:13,
from sound/core/memory.c:9:
./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
'pgd_t'; did you mean 'pid_t'?
#define p4d_t pgd_t
^
./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
'p4d_t'
static inline int p4d_none(p4d_t p4d)
^
It is because "4level-fixup.h" is included before "asm/page.h" where
"pgd_t" is defined.
Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d' set but
not used")
Reported-by: Guenter Roeck
Signed-off-by: Qian Cai
Tested-by: Guenter Roeck
Acked-by: Helge Deller
Helge
Any chance to push this patch into mainline anytime soon ? It has been applied
to -next, but all parisc builds in mainline are still broken.
Thanks,
Guenter
Re: [PATCH] parisc: fix compilation errrors
On 15.08.19 23:02, Guenter Roeck wrote:
On Thu, Aug 15, 2019 at 04:53:05PM -0400, Qian Cai wrote:
The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
variable 'p4d' set but not used") converted a few functions from macros
to static inline, which causes parisc to complain,
In file included from ./include/asm-generic/4level-fixup.h:38:0,
from ./arch/parisc/include/asm/pgtable.h:5,
from ./arch/parisc/include/asm/io.h:6,
from ./include/linux/io.h:13,
from sound/core/memory.c:9:
./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
'pgd_t'; did you mean 'pid_t'?
#define p4d_tpgd_t
^
./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
'p4d_t'
static inline int p4d_none(p4d_t p4d)
^
It is because "4level-fixup.h" is included before "asm/page.h" where
"pgd_t" is defined.
Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d' set but
not used")
Reported-by: Guenter Roeck
Signed-off-by: Qian Cai
Tested-by: Guenter Roeck
Acked-by: Helge Deller
Helge
Re: [PATCH] parisc: fix compilation errrors
On Thu, Aug 15, 2019 at 04:53:05PM -0400, Qian Cai wrote:
> The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
> variable 'p4d' set but not used") converted a few functions from macros
> to static inline, which causes parisc to complain,
>
> In file included from ./include/asm-generic/4level-fixup.h:38:0,
> from ./arch/parisc/include/asm/pgtable.h:5,
> from ./arch/parisc/include/asm/io.h:6,
> from ./include/linux/io.h:13,
> from sound/core/memory.c:9:
> ./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
> 'pgd_t'; did you mean 'pid_t'?
> #define p4d_tpgd_t
> ^
> ./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
> 'p4d_t'
> static inline int p4d_none(p4d_t p4d)
> ^
>
> It is because "4level-fixup.h" is included before "asm/page.h" where
> "pgd_t" is defined.
>
> Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d'
> set but not used")
> Reported-by: Guenter Roeck
> Signed-off-by: Qian Cai
Tested-by: Guenter Roeck
[PATCH] parisc: fix compilation errrors
The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
variable 'p4d' set but not used") converted a few functions from macros
to static inline, which causes parisc to complain,
In file included from ./include/asm-generic/4level-fixup.h:38:0,
from ./arch/parisc/include/asm/pgtable.h:5,
from ./arch/parisc/include/asm/io.h:6,
from ./include/linux/io.h:13,
from sound/core/memory.c:9:
./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
'pgd_t'; did you mean 'pid_t'?
#define p4d_tpgd_t
^
./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
'p4d_t'
static inline int p4d_none(p4d_t p4d)
^
It is because "4level-fixup.h" is included before "asm/page.h" where
"pgd_t" is defined.
Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d'
set but not used")
Reported-by: Guenter Roeck
Signed-off-by: Qian Cai
---
arch/parisc/include/asm/pgtable.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/parisc/include/asm/pgtable.h
b/arch/parisc/include/asm/pgtable.h
index a39b079e73f2..6d58c1739b42 100644
--- a/arch/parisc/include/asm/pgtable.h
+++ b/arch/parisc/include/asm/pgtable.h
@@ -2,6 +2,7 @@
#ifndef _PARISC_PGTABLE_H
#define _PARISC_PGTABLE_H
+#include
#include
#include
@@ -98,8 +99,6 @@ static inline void purge_tlb_entries(struct mm_struct *mm,
unsigned long addr)
#endif /* !__ASSEMBLY__ */
-#include
-
#define pte_ERROR(e) \
printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, pte_val(e))
#define pmd_ERROR(e) \
--
2.20.1 (Apple Git-117)
