Re: [PATCH] perf, tools: Fix sorting for 64bit entries
Em Fri, Sep 27, 2013 at 04:39:24PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > Some of the node comparisons in hist.c dropped the upper > 32bit by using an int variable to store the compare > result. This broke various 64bit fields, causing > incorrect collapsing (found for the TSX transaction field) > > Just use int64_t always. Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf, tools: Fix sorting for 64bit entries
Em Fri, Sep 27, 2013 at 04:39:24PM -0700, Andi Kleen escreveu: From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Thanks, applied. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf, tools: Fix sorting for 64bit entries
Hi Andi, On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote: > From: Andi Kleen > > Some of the node comparisons in hist.c dropped the upper > 32bit by using an int variable to store the compare > result. This broke various 64bit fields, causing > incorrect collapsing (found for the TSX transaction field) > > Just use int64_t always. Acked-by: Namhyung Kim Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf, tools: Fix sorting for 64bit entries
Hi Andi, On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Acked-by: Namhyung Kim namhy...@kernel.org Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf, tools: Fix sorting for 64bit entries
From: Andi Kleen Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Signed-off-by: Andi Kleen --- tools/perf/util/hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 4714a72..4832b59 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -350,7 +350,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists, struct rb_node **p; struct rb_node *parent = NULL; struct hist_entry *he; - int cmp; + int64_t cmp; p = >entries_in->rb_node; @@ -887,7 +887,7 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, struct rb_node **p; struct rb_node *parent = NULL; struct hist_entry *he; - int cmp; + int64_t cmp; if (sort__need_collapse) root = >entries_collapsed; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf, tools: Fix sorting for 64bit entries
From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Signed-off-by: Andi Kleen a...@linux.intel.com --- tools/perf/util/hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 4714a72..4832b59 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -350,7 +350,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists, struct rb_node **p; struct rb_node *parent = NULL; struct hist_entry *he; - int cmp; + int64_t cmp; p = hists-entries_in-rb_node; @@ -887,7 +887,7 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, struct rb_node **p; struct rb_node *parent = NULL; struct hist_entry *he; - int cmp; + int64_t cmp; if (sort__need_collapse) root = hists-entries_collapsed; -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
