Re: [PATCH] perf tools: set kernel end address properly

2018-04-24 Thread Ard Biesheuvel
On 24 April 2018 at 14:50, Kim Phillips wrote: > On Tue, 24 Apr 2018 08:13:57 +0200 > Ard Biesheuvel wrote: > >> On 23 April 2018 at 23:43, Kim Phillips wrote: >> > arch__normalize_symbol_name() is a place where architecture code can >> > clean up symbol names in perf, and I thought module_emit_

Re: [PATCH] perf tools: set kernel end address properly

2018-04-24 Thread Kim Phillips
On Tue, 24 Apr 2018 08:13:57 +0200 Ard Biesheuvel wrote: > On 23 April 2018 at 23:43, Kim Phillips wrote: > > arch__normalize_symbol_name() is a place where architecture code can > > clean up symbol names in perf, and I thought module_emit_adrp_veneer() > > was a veneer itself, but it seems that

Re: [PATCH] perf tools: set kernel end address properly

2018-04-23 Thread Ard Biesheuvel
On 23 April 2018 at 23:43, Kim Phillips wrote: > On Fri, 20 Apr 2018 10:10:32 +0200 > Ard Biesheuvel wrote: > >> On 20 April 2018 at 01:33, Kim Phillips wrote: >> > On Thu, 19 Apr 2018 11:54:24 +0900 >> > Namhyung Kim wrote: >> > >> >> On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrot

Re: [PATCH] perf tools: set kernel end address properly

2018-04-23 Thread Kim Phillips
On Fri, 20 Apr 2018 10:10:32 +0200 Ard Biesheuvel wrote: > On 20 April 2018 at 01:33, Kim Phillips wrote: > > On Thu, 19 Apr 2018 11:54:24 +0900 > > Namhyung Kim wrote: > > > >> On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > >> > diff --git a/tools/perf/arch/arm64/util/sym-hand

Re: [PATCH] perf tools: set kernel end address properly

2018-04-23 Thread Kim Phillips
On Mon, 23 Apr 2018 10:52:21 -0300 Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 20, 2018 at 06:23:58PM -0500, Kim Phillips escreveu: > > On Fri, 20 Apr 2018 08:59:15 +0900 > > Namhyung Kim wrote: > > > > > The map_groups__fixup_end() was called to set end addresses of kernel > > > map and modu

Re: [PATCH] perf tools: set kernel end address properly

2018-04-23 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 20, 2018 at 06:23:58PM -0500, Kim Phillips escreveu: > On Fri, 20 Apr 2018 08:59:15 +0900 > Namhyung Kim wrote: > > > The map_groups__fixup_end() was called to set end addresses of kernel > > map and module maps. But now machine__create_modules() is set the end > > address of modules

Re: [PATCH] perf tools: set kernel end address properly

2018-04-20 Thread Kim Phillips
On Fri, 20 Apr 2018 08:59:15 +0900 Namhyung Kim wrote: > The map_groups__fixup_end() was called to set end addresses of kernel > map and module maps. But now machine__create_modules() is set the end > address of modules properly, the only remaining piece is the kernel map. > We can set it with a

Re: [PATCH] perf tools: set kernel end address properly

2018-04-20 Thread Ard Biesheuvel
On 20 April 2018 at 01:33, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:54:24 +0900 > Namhyung Kim wrote: > >> On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: >> > diff --git a/tools/perf/arch/arm64/util/sym-handling.c >> > b/tools/perf/arch/arm64/util/sym-handling.c >> > index 005

Re: [PATCH] perf tools: set kernel end address properly

2018-04-19 Thread Namhyung Kim
On Thu, Apr 19, 2018 at 06:33:13PM -0500, Kim Phillips wrote: > On Thu, 19 Apr 2018 11:54:24 +0900 > Namhyung Kim wrote: > > > On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > > > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > > > b/tools/perf/arch/arm64/util/sym-handlin

Re: [PATCH] perf tools: set kernel end address properly

2018-04-19 Thread Namhyung Kim
you'd do a better job on > writing the commit text, so would you care to, please? Sure, what about this? Thanks, Namhyung >From 1d9fa3b21bd7a964af43dcc9d486a09917d795e9 Mon Sep 17 00:00:00 2001 From: Namhyung Kim Date: Mon, 19 Feb 2018 19:05:45 +0900 Subject: [PATCH] perf tools: set ke

Re: [PATCH] perf tools: set kernel end address properly

2018-04-19 Thread Kim Phillips
On Thu, 19 Apr 2018 11:54:24 +0900 Namhyung Kim wrote: > On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > > b/tools/perf/arch/arm64/util/sym-handling.c > > index 0051b1ee8450..5c4a2e208bbc 100644 > > --- a/tools/perf/arch/

Re: [PATCH] perf tools: set kernel end address properly

2018-04-19 Thread Kim Phillips
On Thu, 19 Apr 2018 11:37:12 +0900 Namhyung Kim wrote: > On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > > On Tue, 17 Apr 2018 11:27:26 +0900 > > Namhyung Kim wrote: > > > On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > > > > > a perf/urgent from last week (commit

Re: [PATCH] perf tools: set kernel end address properly

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > b/tools/perf/arch/arm64/util/sym-handling.c > index 0051b1ee8450..5c4a2e208bbc 100644 > --- a/tools/perf/arch/arm64/util/sym-handling.c > +++ b/tools/perf/arch/arm64/util/sym-ha

Re: [PATCH] perf tools: set kernel end address properly

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > On Tue, 17 Apr 2018 11:27:26 +0900 > Namhyung Kim wrote: > > On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > > > > a perf/urgent from last week (commit 918965d4897) + this patch: > > > > > > > > $ sudo ./perf test -vv

Re: [PATCH] perf tools: set kernel end address properly

2018-04-18 Thread Kim Phillips
he machine__set_kernel_mmap() call, and test 1 still fails. > > I guess it was overwritten by the machine__set_kernel_mmap() then. Yes. > > The problem is earlier on in the code, somewhere. > > To be sure, could you please show me the /proc/kallsymb output around > the missing symbols (do_u

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Namhyung Kim
On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > On Mon, 16 Apr 2018 12:24:07 -0500 > Kim Phillips wrote: > > > On Mon, 16 Apr 2018 13:58:00 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > Em Mon, Apr 16, 2018 at 11:07:30AM -0500, Kim Phillips escreveu: > > > > On Mon, 16 Apr

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Kim Phillips
On Mon, 16 Apr 2018 12:24:07 -0500 Kim Phillips wrote: > On Mon, 16 Apr 2018 13:58:00 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Mon, Apr 16, 2018 at 11:07:30AM -0500, Kim Phillips escreveu: > > > On Mon, 16 Apr 2018 10:51:25 -0300 > > > Arnaldo Carvalho de Melo wrote: > > > > > > > Em

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Kim Phillips
On Mon, 16 Apr 2018 13:58:00 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 16, 2018 at 11:07:30AM -0500, Kim Phillips escreveu: > > On Mon, 16 Apr 2018 10:51:25 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > > > > On Mon

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 16, 2018 at 11:07:30AM -0500, Kim Phillips escreveu: > On Mon, 16 Apr 2018 10:51:25 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > > > On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote: > > > > The map_groups__f

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Kim Phillips
On Mon, 16 Apr 2018 10:51:25 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > > On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote: > > > The map_groups__fixup_end() was called to set end addresses of kernel > > > map and module map

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu: > On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote: > > The map_groups__fixup_end() was called to set end addresses of kernel > > map and module maps. But now machine__create_modules() is set the end > > address of modules p

Re: [PATCH] perf tools: set kernel end address properly

2018-04-16 Thread Jiri Olsa
On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote: > The map_groups__fixup_end() was called to set end addresses of kernel > map and module maps. But now machine__create_modules() is set the end > address of modules properly so the only remaining piece is the kernel > map. We can set i

[PATCH] perf tools: set kernel end address properly

2018-04-15 Thread Namhyung Kim
The map_groups__fixup_end() was called to set end addresses of kernel map and module maps. But now machine__create_modules() is set the end address of modules properly so the only remaining piece is the kernel map. We can set it with adjacent module's address directly instead of calling the map_g