Re: [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Linus Walleij]

On Tue, Nov 13, 2012 at 2:00 AM, Axel Lin  wrote:

> Current code sets "pin_reg = >pin_regs[i];" in each loop iteration,
> so in the case of no-match, pin_reg is not NULL.
>
> Signed-off-by: Axel Lin 

Thanks, applied with Dong's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Linus Walleij]

On Tue, Nov 13, 2012 at 2:00 AM, Axel Lin axel@ingics.com wrote:

 Current code sets pin_reg = info-pin_regs[i]; in each loop iteration,
 so in the case of no-match, pin_reg is not NULL.

 Signed-off-by: Axel Lin axel@ingics.com

Thanks, applied with Dong's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Dong Aisheng]

On Tue, Nov 13, 2012 at 09:00:07AM +0800, Axel Lin wrote:
> Current code sets "pin_reg = >pin_regs[i];" in each loop iteration,
> so in the case of no-match, pin_reg is not NULL.
> 
> Signed-off-by: Axel Lin 

Thanks for the fix.
Acked-by: Dong Aisheng 

Regards
Dong Aisheng
> ---
>  drivers/pinctrl/pinctrl-imx.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> index f3d2384..525a2c8 100644
> --- a/drivers/pinctrl/pinctrl-imx.c
> +++ b/drivers/pinctrl/pinctrl-imx.c
> @@ -71,7 +71,7 @@ static const struct imx_pin_reg *imx_find_pin_reg(
>   break;
>   }
>  
> - if (!pin_reg) {
> + if (i == info->npin_regs) {
>   dev_err(info->dev, "Pin(%s): unable to find pin reg map\n",
>   info->pins[pin].name);
>   return NULL;
> -- 
> 1.7.9.5
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Axel Lin]

Current code sets "pin_reg = >pin_regs[i];" in each loop iteration,
so in the case of no-match, pin_reg is not NULL.

Signed-off-by: Axel Lin 
---
 drivers/pinctrl/pinctrl-imx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index f3d2384..525a2c8 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -71,7 +71,7 @@ static const struct imx_pin_reg *imx_find_pin_reg(
break;
}
 
-   if (!pin_reg) {
+   if (i == info->npin_regs) {
dev_err(info->dev, "Pin(%s): unable to find pin reg map\n",
info->pins[pin].name);
return NULL;
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Axel Lin]

Current code sets pin_reg = info-pin_regs[i]; in each loop iteration,
so in the case of no-match, pin_reg is not NULL.

Signed-off-by: Axel Lin axel@ingics.com
---
 drivers/pinctrl/pinctrl-imx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index f3d2384..525a2c8 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -71,7 +71,7 @@ static const struct imx_pin_reg *imx_find_pin_reg(
break;
}
 
-   if (!pin_reg) {
+   if (i == info-npin_regs) {
dev_err(info-dev, Pin(%s): unable to find pin reg map\n,
info-pins[pin].name);
return NULL;
-- 
1.7.9.5



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pinctrl: imx: Fix the logic checking if not able to find pin reg map

[Dong Aisheng]

On Tue, Nov 13, 2012 at 09:00:07AM +0800, Axel Lin wrote:
 Current code sets pin_reg = info-pin_regs[i]; in each loop iteration,
 so in the case of no-match, pin_reg is not NULL.
 
 Signed-off-by: Axel Lin axel@ingics.com

Thanks for the fix.
Acked-by: Dong Aisheng dong.aish...@linaro.org

Regards
Dong Aisheng
 ---
  drivers/pinctrl/pinctrl-imx.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
 index f3d2384..525a2c8 100644
 --- a/drivers/pinctrl/pinctrl-imx.c
 +++ b/drivers/pinctrl/pinctrl-imx.c
 @@ -71,7 +71,7 @@ static const struct imx_pin_reg *imx_find_pin_reg(
   break;
   }
  
 - if (!pin_reg) {
 + if (i == info-npin_regs) {
   dev_err(info-dev, Pin(%s): unable to find pin reg map\n,
   info-pins[pin].name);
   return NULL;
 -- 
 1.7.9.5
 
 
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/