Re: [PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-04-01 Thread Preeti U Murthy 
On 03/31/2015 09:41 PM, Jan Stancek wrote:
> Space allocated for paca is based off nr_cpu_ids,
> but pnv_alloc_idle_core_states() iterates paca with
> cpu_nr_cores()*threads_per_core, which is using NR_CPUS.
> 
> This causes pnv_alloc_idle_core_states() to write over memory,
> which is outside of paca array and may later lead to various panics.
> 
> Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
> Signed-off-by: Jan Stancek 
> ---
>  arch/powerpc/include/asm/cputhreads.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/include/asm/cputhreads.h 
> b/arch/powerpc/include/asm/cputhreads.h
> index 2bf8e93..4c8ad59 100644
> --- a/arch/powerpc/include/asm/cputhreads.h
> +++ b/arch/powerpc/include/asm/cputhreads.h
> @@ -55,7 +55,7 @@ static inline cpumask_t cpu_thread_mask_to_cores(const 
> struct cpumask *threads)
> 
>  static inline int cpu_nr_cores(void)
>  {
> - return NR_CPUS >> threads_shift;
> + return nr_cpu_ids >> threads_shift;
>  }

Thanks for the patch!

Reviewed-by: Preeti U. Murthy 
> 
>  static inline cpumask_t cpu_online_cores_map(void)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-04-01 Thread Preeti U Murthy 
On 03/31/2015 09:41 PM, Jan Stancek wrote:
 Space allocated for paca is based off nr_cpu_ids,
 but pnv_alloc_idle_core_states() iterates paca with
 cpu_nr_cores()*threads_per_core, which is using NR_CPUS.
 
 This causes pnv_alloc_idle_core_states() to write over memory,
 which is outside of paca array and may later lead to various panics.
 
 Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
 Signed-off-by: Jan Stancek jstan...@redhat.com
 ---
  arch/powerpc/include/asm/cputhreads.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/arch/powerpc/include/asm/cputhreads.h 
 b/arch/powerpc/include/asm/cputhreads.h
 index 2bf8e93..4c8ad59 100644
 --- a/arch/powerpc/include/asm/cputhreads.h
 +++ b/arch/powerpc/include/asm/cputhreads.h
 @@ -55,7 +55,7 @@ static inline cpumask_t cpu_thread_mask_to_cores(const 
 struct cpumask *threads)
 
  static inline int cpu_nr_cores(void)
  {
 - return NR_CPUS  threads_shift;
 + return nr_cpu_ids  threads_shift;
  }

Thanks for the patch!

Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
 
  static inline cpumask_t cpu_online_cores_map(void)
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-03-31 Thread Michael Ellerman 
On Tue, 2015-03-31 at 18:11 +0200, Jan Stancek wrote:
> Space allocated for paca is based off nr_cpu_ids,
> but pnv_alloc_idle_core_states() iterates paca with
> cpu_nr_cores()*threads_per_core, which is using NR_CPUS.
> 
> This causes pnv_alloc_idle_core_states() to write over memory,
> which is outside of paca array and may later lead to various panics.
> 
> Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
> Signed-off-by: Jan Stancek 

Thanks. I'll send that to Linus in the next day or two and mark it for stable
as well.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-03-31 Thread Jan Stancek 
Space allocated for paca is based off nr_cpu_ids,
but pnv_alloc_idle_core_states() iterates paca with
cpu_nr_cores()*threads_per_core, which is using NR_CPUS.

This causes pnv_alloc_idle_core_states() to write over memory,
which is outside of paca array and may later lead to various panics.

Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
Signed-off-by: Jan Stancek 
---
 arch/powerpc/include/asm/cputhreads.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/cputhreads.h 
b/arch/powerpc/include/asm/cputhreads.h
index 2bf8e93..4c8ad59 100644
--- a/arch/powerpc/include/asm/cputhreads.h
+++ b/arch/powerpc/include/asm/cputhreads.h
@@ -55,7 +55,7 @@ static inline cpumask_t cpu_thread_mask_to_cores(const struct 
cpumask *threads)
 
 static inline int cpu_nr_cores(void)
 {
-   return NR_CPUS >> threads_shift;
+   return nr_cpu_ids >> threads_shift;
 }
 
 static inline cpumask_t cpu_online_cores_map(void)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-03-31 Thread Michael Ellerman 
On Tue, 2015-03-31 at 18:11 +0200, Jan Stancek wrote:
 Space allocated for paca is based off nr_cpu_ids,
 but pnv_alloc_idle_core_states() iterates paca with
 cpu_nr_cores()*threads_per_core, which is using NR_CPUS.
 
 This causes pnv_alloc_idle_core_states() to write over memory,
 which is outside of paca array and may later lead to various panics.
 
 Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
 Signed-off-by: Jan Stancek jstan...@redhat.com

Thanks. I'll send that to Linus in the next day or two and mark it for stable
as well.

cheers


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] powerpc: fix memory corruption by pnv_alloc_idle_core_states

2015-03-31 Thread Jan Stancek 
Space allocated for paca is based off nr_cpu_ids,
but pnv_alloc_idle_core_states() iterates paca with
cpu_nr_cores()*threads_per_core, which is using NR_CPUS.

This causes pnv_alloc_idle_core_states() to write over memory,
which is outside of paca array and may later lead to various panics.

Fixes: 7cba160ad789 (powernv/cpuidle: Redesign idle states management)
Signed-off-by: Jan Stancek jstan...@redhat.com
---
 arch/powerpc/include/asm/cputhreads.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/cputhreads.h 
b/arch/powerpc/include/asm/cputhreads.h
index 2bf8e93..4c8ad59 100644
--- a/arch/powerpc/include/asm/cputhreads.h
+++ b/arch/powerpc/include/asm/cputhreads.h
@@ -55,7 +55,7 @@ static inline cpumask_t cpu_thread_mask_to_cores(const struct 
cpumask *threads)
 
 static inline int cpu_nr_cores(void)
 {
-   return NR_CPUS  threads_shift;
+   return nr_cpu_ids  threads_shift;
 }
 
 static inline cpumask_t cpu_online_cores_map(void)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/