On 02/09/18 at 06:15pm, Sergey Senozhatsky wrote:
> On (02/09/18 17:00), Dave Young wrote:
> [..]
> > >
> > > I'm hesitating to add #ifdef CONFIG_PRINTK in lib/dump_stack.c.
>
> Agreed.
>
> > Maybe conditionally build dump_stack.o only when CONFIG_PRINTK is true,
> > but not sure if there are som
On (02/09/18 17:00), Dave Young wrote:
[..]
> >
> > I'm hesitating to add #ifdef CONFIG_PRINTK in lib/dump_stack.c.
Agreed.
> Maybe conditionally build dump_stack.o only when CONFIG_PRINTK is true,
> but not sure if there are some historic reason this is not done before,
> will do some testing se
On 02/09/18 at 04:51pm, Dave Young wrote:
> On 02/09/18 at 05:42pm, Sergey Senozhatsky wrote:
> > On (02/09/18 16:27), Dave Young wrote:
> > > > Seems that those functions are still defined in printk header.
> > > > Did you test !CONFIG_PRINTK build?
> >
> > Apparently dump_stack(void) is also in
On 02/09/18 at 05:42pm, Sergey Senozhatsky wrote:
> On (02/09/18 16:27), Dave Young wrote:
> > > Seems that those functions are still defined in printk header.
> > > Did you test !CONFIG_PRINTK build?
>
> Apparently dump_stack(void) is also in printk.h
>
> extern asmlinkage void dump_stack(void)
On (02/09/18 16:27), Dave Young wrote:
> > Seems that those functions are still defined in printk header.
> > Did you test !CONFIG_PRINTK build?
Apparently dump_stack(void) is also in printk.h
extern asmlinkage void dump_stack(void) __cold;
so it's "OK" to keep those functions in printk.h, I gue
On 02/09/18 at 05:16pm, Sergey Senozhatsky wrote:
> Hi,
>
> On (02/09/18 16:06), Dave Young wrote:
> [..]
> > +void __init dump_stack_set_arch_desc(const char *fmt, ...)
> ..
> > +void dump_stack_print_info(const char *log_lvl)
> ..
> > +void show_regs_print_info(const char *log_lvl)
> ..
>
> See
On 02/09/18 at 05:16pm, Sergey Senozhatsky wrote:
> Hi,
>
> On (02/09/18 16:06), Dave Young wrote:
> [..]
> > +void __init dump_stack_set_arch_desc(const char *fmt, ...)
> ..
> > +void dump_stack_print_info(const char *log_lvl)
> ..
> > +void show_regs_print_info(const char *log_lvl)
> ..
>
> See
Hi,
On (02/09/18 16:06), Dave Young wrote:
[..]
> +void __init dump_stack_set_arch_desc(const char *fmt, ...)
..
> +void dump_stack_print_info(const char *log_lvl)
..
> +void show_regs_print_info(const char *log_lvl)
..
Seems that those functions are still defined in printk header.
Did you test !
dump_stack related stuff should belong to lib/dump_stack.c thus move them
there.
Signed-off-by: Dave Young
Suggested-by: Steven Rostedt
Suggested-by: Sergey Senozhatsky
---
Note: dump stack etc still share printk.h as before, I would keep it as is
since a lot of files need it.
This patch is bas
9 matches
Mail list logo