Re: [PATCH] proc: report eip and esp for all threads when coredumping

2019-05-26 Thread John Ogness
Hi Andrew, On 2019-05-25, Andrew Morton wrote: > Please send along a signed-off-by: for this? >From my response: On 2019-05-25, John Ogness wrote: > AFAICT core_state does not need to be set before the other lines. But > there may be some side effects that I overlooked! The changes I showed

Re: [PATCH] proc: report eip and esp for all threads when coredumping

2019-05-24 Thread John Ogness
On 2019-05-22, Jan Luebbe wrote: > Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in > /proc/PID/stat") stopped reporting eip/esp and commit fd7d56270b52 > ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") > reintroduced the feature to fix a regression with userspace core

Re: [PATCH] proc: report eip and esp for all threads when coredumping

2019-05-23 Thread Jan Lübbe
On Wed, 2019-05-22 at 11:00 -0700, Andrew Morton wrote: > On Wed, 22 May 2019 18:16:14 +0200 Jan Luebbe wrote: > > > Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in > > /proc/PID/stat") stopped reporting eip/esp and commit fd7d56270b52 > > ("fs/proc: Report eip/esp in /prod/PID/stat

Re: [PATCH] proc: report eip and esp for all threads when coredumping

2019-05-22 Thread Andrew Morton
On Wed, 22 May 2019 18:16:14 +0200 Jan Luebbe wrote: > Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in > /proc/PID/stat") stopped reporting eip/esp and commit fd7d56270b52 > ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") > reintroduced the feature to fix a regression

Re: [PATCH] proc: report eip and esp for all threads when coredumping

2019-05-22 Thread Alexey Dobriyan
On Wed, May 22, 2019 at 06:16:14PM +0200, Jan Luebbe wrote: > --- a/fs/proc/array.c > +++ b/fs/proc/array.c > @@ -462,7 +462,7 @@ static int do_task_stat(struct seq_file *m, struct > pid_namespace *ns, >* a program is not able to use ptrace(2) in that case. It is >

[PATCH] proc: report eip and esp for all threads when coredumping

2019-05-22 Thread Jan Luebbe
Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in /proc/PID/stat") stopped reporting eip/esp and commit fd7d56270b52 ("fs/proc: Report eip/esp in /prod/PID/stat for coredumping") reintroduced the feature to fix a regression with userspace core dump handlers (such as minicoredumper).