Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-12 Thread Paul E. McKenney
On Mon, Mar 12, 2018 at 01:28:38PM +0800, Boqun Feng wrote: > On Fri, Mar 09, 2018 at 12:17:07PM -0800, Paul E. McKenney wrote: > > On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > > > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > > > On Thu, Mar 08, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-12 Thread Paul E. McKenney
On Mon, Mar 12, 2018 at 01:28:38PM +0800, Boqun Feng wrote: > On Fri, Mar 09, 2018 at 12:17:07PM -0800, Paul E. McKenney wrote: > > On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > > > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > > > On Thu, Mar 08, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-11 Thread Boqun Feng
On Fri, Mar 09, 2018 at 12:17:07PM -0800, Paul E. McKenney wrote: > On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > > > On Thu, Mar 08, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-11 Thread Boqun Feng
On Fri, Mar 09, 2018 at 12:17:07PM -0800, Paul E. McKenney wrote: > On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > > > On Thu, Mar 08, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-09 Thread Paul E. McKenney
On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > > > On Wed, Mar 07, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-09 Thread Paul E. McKenney
On Fri, Mar 09, 2018 at 02:57:00PM +0800, Boqun Feng wrote: > On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > > > On Wed, Mar 07, 2018 at

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Boqun Feng
On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > > > [...] > > > > > > > > > >

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Boqun Feng
On Thu, Mar 08, 2018 at 07:42:55AM -0800, Paul E. McKenney wrote: > On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > > > [...] > > > > > > > > > >

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Paul E. McKenney
On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > > [...] > > > > > > > > +/* > > > > + * Like sync_rcu_preempt_exp_done(), but this function assumes

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Paul E. McKenney
On Thu, Mar 08, 2018 at 04:30:06PM +0800, Boqun Feng wrote: > On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > > [...] > > > > > > > > +/* > > > > + * Like sync_rcu_preempt_exp_done(), but this function assumes

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Boqun Feng
On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > [...] > > > > > > +/* > > > + * Like sync_rcu_preempt_exp_done(), but this function assumes the caller > > > + * doesn't hold the rcu_node's ->lock, and will acquire

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-08 Thread Boqun Feng
On Thu, Mar 08, 2018 at 12:54:29PM +0800, Boqun Feng wrote: > On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: > [...] > > > > > > +/* > > > + * Like sync_rcu_preempt_exp_done(), but this function assumes the caller > > > + * doesn't hold the rcu_node's ->lock, and will acquire

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: [...] > > > > +/* > > + * Like sync_rcu_preempt_exp_done(), but this function assumes the caller > > + * doesn't hold the rcu_node's ->lock, and will acquire and release the > > lock > > + * itself > > + */ > > +static bool

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
On Wed, Mar 07, 2018 at 08:30:17PM -0800, Paul E. McKenney wrote: [...] > > > > +/* > > + * Like sync_rcu_preempt_exp_done(), but this function assumes the caller > > + * doesn't hold the rcu_node's ->lock, and will acquire and release the > > lock > > + * itself > > + */ > > +static bool

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Paul E. McKenney
On Thu, Mar 08, 2018 at 11:46:27AM +0800, Boqun Feng wrote: > On Wed, Mar 07, 2018 at 07:48:29AM -0800, Paul E. McKenney wrote: > > On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > > > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > > > preemptible RCU"),

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Paul E. McKenney
On Thu, Mar 08, 2018 at 11:46:27AM +0800, Boqun Feng wrote: > On Wed, Mar 07, 2018 at 07:48:29AM -0800, Paul E. McKenney wrote: > > On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > > > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > > > preemptible RCU"),

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
On Wed, Mar 07, 2018 at 07:48:29AM -0800, Paul E. McKenney wrote: > On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > > preemptible RCU"), there are comments for some funtions in > > rcu_report_exp_rnp()'s

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
On Wed, Mar 07, 2018 at 07:48:29AM -0800, Paul E. McKenney wrote: > On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > > preemptible RCU"), there are comments for some funtions in > > rcu_report_exp_rnp()'s

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Paul E. McKenney
On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > preemptible RCU"), there are comments for some funtions in > rcu_report_exp_rnp()'s call-chain saying that exp_mutex or its > predecessors needs to be held. > >

Re: [PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Paul E. McKenney
On Wed, Mar 07, 2018 at 04:49:39PM +0800, Boqun Feng wrote: > Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for > preemptible RCU"), there are comments for some funtions in > rcu_report_exp_rnp()'s call-chain saying that exp_mutex or its > predecessors needs to be held. > >

[PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for preemptible RCU"), there are comments for some funtions in rcu_report_exp_rnp()'s call-chain saying that exp_mutex or its predecessors needs to be held. However, exp_mutex and its predecessors are merely used for synchronize

[PATCH] rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

2018-03-07 Thread Boqun Feng
Since commit d9a3da0699b2 ("rcu: Add expedited grace-period support for preemptible RCU"), there are comments for some funtions in rcu_report_exp_rnp()'s call-chain saying that exp_mutex or its predecessors needs to be held. However, exp_mutex and its predecessors are merely used for synchronize