Re: [PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-26 Thread Paul Moore
Mon, Mar 23, 2015 at 9:01 PM, Joe Perches wrote: > Return a negative error value like the rest > of the entries in this function. > > Signed-off-by: Joe Perches > --- > Maybe this should be stable, it goes back to > commit b77a493b1dc8 ("SELinux: standardize return code > handling in

Re: [PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-26 Thread Paul Moore
Mon, Mar 23, 2015 at 9:01 PM, Joe Perches j...@perches.com wrote: Return a negative error value like the rest of the entries in this function. Signed-off-by: Joe Perches j...@perches.com --- Maybe this should be stable, it goes back to commit b77a493b1dc8 (SELinux: standardize return code

Re: [PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-24 Thread Stephen Smalley
On 03/23/2015 09:01 PM, Joe Perches wrote: > Return a negative error value like the rest > of the entries in this function. > > Signed-off-by: Joe Perches Acked-by: Stephen Smalley > --- > Maybe this should be stable, it goes back to > commit b77a493b1dc8 ("SELinux: standardize return code >

Re: [PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-24 Thread Stephen Smalley
On 03/23/2015 09:01 PM, Joe Perches wrote: Return a negative error value like the rest of the entries in this function. Signed-off-by: Joe Perches j...@perches.com Acked-by: Stephen Smalley s...@tycho.nsa.gov --- Maybe this should be stable, it goes back to commit b77a493b1dc8 (SELinux:

[PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-23 Thread Joe Perches
Return a negative error value like the rest of the entries in this function. Signed-off-by: Joe Perches --- Maybe this should be stable, it goes back to commit b77a493b1dc8 ("SELinux: standardize return code handling in selinuxfs.c") back in Nov 2010, but it's guarded by a #ifdef

[PATCH] selinuxfs: Fix sel_write_enforce broken return value

2015-03-23 Thread Joe Perches
Return a negative error value like the rest of the entries in this function. Signed-off-by: Joe Perches j...@perches.com --- Maybe this should be stable, it goes back to commit b77a493b1dc8 (SELinux: standardize return code handling in selinuxfs.c) back in Nov 2010, but it's guarded by a #ifdef